From 20a06d8c2de082d169fab01c96b41306d5fc974d Mon Sep 17 00:00:00 2001 From: "kevin.ong" Date: Tue, 14 May 2019 22:39:42 +0800 Subject: [PATCH 1/2] cellular: fix Quectel BG96 missing unlock at socket_connect --- .../targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp b/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp index 834c7a0ff02..7b5003e4bf6 100644 --- a/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp +++ b/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp @@ -70,6 +70,7 @@ nsapi_error_t QUECTEL_BG96_CellularStack::socket_connect(nsapi_socket_t handle, if ((_at.get_last_error() == NSAPI_ERROR_OK) && err) { if (err == BG96_SOCKET_BIND_FAIL) { socket->created = false; + _at.unlock(); return NSAPI_ERROR_PARAMETER; } _at.cmd_start("AT+QICLOSE="); @@ -177,6 +178,7 @@ void QUECTEL_BG96_CellularStack::handle_open_socket_response(int &modem_connect_ modem_connect_id = _at.read_int(); err = _at.read_int(); } + nsapi_error_t QUECTEL_BG96_CellularStack::create_socket_impl(CellularSocket *socket) { int modem_connect_id = -1; From 75162f9e1aa086a68471075c9f95b9a39d13c669 Mon Sep 17 00:00:00 2001 From: "kevin.ong" Date: Wed, 15 May 2019 01:08:11 +0800 Subject: [PATCH 2/2] cellular: fix style --- .../targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp b/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp index 7b5003e4bf6..11b0b707317 100644 --- a/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp +++ b/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp @@ -70,7 +70,7 @@ nsapi_error_t QUECTEL_BG96_CellularStack::socket_connect(nsapi_socket_t handle, if ((_at.get_last_error() == NSAPI_ERROR_OK) && err) { if (err == BG96_SOCKET_BIND_FAIL) { socket->created = false; - _at.unlock(); + _at.unlock(); return NSAPI_ERROR_PARAMETER; } _at.cmd_start("AT+QICLOSE=");