STM32F1 USBDevice #13406

Allmoz · 2020-08-10T13:09:58Z

Summary of changes

As requested in #13350

Assignation of the USB low priority interrupts for the USB interrupt for the STM32F1 target family. This should enable USB capability in F103 ( and hopefully in F102, and F105/F107 also).

Modified MCU_STM32F103x8 target files to add the needed peripheral definitions and clock configuration (same as NUCLEO_STM32F103RB now) to enable USBDEVICE on MCU_STM32F103x8 based boards.

Tested on a STM32F103C8 and STM32F103RE.

Tested on a NUCLEO_F103RB by @jeromecoutant

Impact of changes

Migration actions required

Documentation

None that I know

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant I'm not sure if adding it to the full STM32F1 is ok since I only tested it for STM32F103C8 and STM32F103RE.
I suppose "Test results" is "Covered by existing mbed-os tests", please confirm.

Best regards

ciarmcom · 2020-08-10T15:00:33Z

@Allmoz, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

adbridge · 2020-08-12T11:51:11Z

@Allmoz as this is actually a target update please change the PR type to patch. Also please fill in an actual summary for the PR rather than just quoting something else, thank you.

Allmoz · 2020-08-12T18:34:39Z

Thanks @adbridge , done.

jeromecoutant

Tested with NUCLEO-F103RB:

USB-DP connected to PA12
USB-DM connected to PA11
1.5KOhm pull up to USB-DP PA12

jeromecoutant · 2020-08-14T13:32:34Z

targets/targets.json

@@ -1280,7 +1280,8 @@
        "device_has_add": [
            "CAN",
            "SERIAL_ASYNCH",
-            "FLASH"
+            "FLASH",
+            "USBDEVICE"


No, we can't add it there, as USBDEVICEmeans you have an USB connector.
This can be only defined in each target (in you custom_target.json)

jeromecoutant · 2020-08-14T15:14:48Z

Maybe you could also check and add my commit in your PR ? :-)
jeromecoutant@f096704

Allmoz · 2020-08-14T16:29:00Z

@jeromecoutant , ohhh i wanna test it so bad. does it fix that the USB issue that is not recognized after programming unless you connect->disconnect->connect?

Sure I will add it.

mergify · 2020-08-14T18:32:22Z

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Allmoz · 2020-08-14T20:08:23Z

Maybe you could also check and add my commit in your PR ? :-)
jeromecoutant@f096704

Awesome, it works on the STM32F103C8 and STM32F103RE.

To achieve that behavior i was using:

serial.connect();
serial.disconnect();
ThisThread::sleep_for(1s);
serial.connect();

Checked and added :)

@adbridge with @jeromecoutant commit this turns also into a "[x] Feature update" ?

0xc0170 · 2020-08-31T11:44:47Z

@adbridge with @jeromecoutant commit this turns also into a "[x] Feature update" ?

The feature is already there, this is just enabling it for a target - it is a patch update.

Thanks @Allmoz for the contribution.

DesktopMan · 2020-08-31T18:50:55Z

Will these changes apply to STM32F103CB as well?

jeromecoutant · 2020-09-01T07:18:57Z

Will these changes apply to STM32F103CB as well?

I think so
Custom target with STM32F103CB should inherit from MCU_STM32F103xB

0xc0170 · 2020-09-01T08:23:45Z

CI started

mbed-ci · 2020-09-01T09:05:28Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	❌
jenkins-ci/mbed-os-ci_build-GCC_ARM	❌

jeromecoutant · 2020-09-01T09:10:50Z

Jenkins CI Test : ❌ FAILED

@Allmoz
Build failure is my fault...
Remove my commit, then let's re-start CI, and merge.
I will then propose the updates in a new PR
Sorry

0xc0170 · 2020-09-10T14:42:30Z

I'll schedule CI soon

mbed-ci · 2020-09-10T16:09:44Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️

0xc0170 · 2020-09-15T07:41:47Z

Once we release the next Mbed OS version, we'll merge this.

wubaojun1982 · 2020-09-17T07:59:52Z

still can't use USBSerial on bluepill (STM32F103C8T6) board.

Allmoz · 2020-09-17T15:01:55Z

still can't use USBSerial on bluepill (STM32F103C8T6) board.

you need to have the device declared in your custom_target.json:

    "device_has_add": [
        "USBDEVICE"
    ]

the pin map in your custom PeripheralPins.c :

//*** USBDEVICE ***

MBED_WEAK const PinMap PinMap_USB_FS[] = {
{PA_11, USB_FS, STM_PIN_DATA(STM_MODE_INPUT, GPIO_NOPULL, 0)}, // USB_DM
{PA_12, USB_FS, STM_PIN_DATA(STM_MODE_INPUT, GPIO_NOPULL, 0)}, // USB_DP
{NC, NC, 0}
};

and the pin names in the custom PinNames.h

//USB pins
USB_DM = PA_11,
USB_DP = PA_12,

wubaojun1982 · 2020-09-18T01:11:51Z

https://os.mbed.com/users/hudakz/code/mbed-os-bluepill/shortlog/
can you do it like this, using the USBSerial with bluepill(stm32f103c8t6).

wubaojun1982 · 2020-09-18T16:33:47Z

it can work successful, I added the clock source configuration in the med_app.json like this:
"target_overrides": {
"*": {
"target.clock_source": "USE_PLL_HSE_XTAL",
"target.clock_source_usb": "1",
"target.device_has_add": ["USBDEVICE"]
}
}

JojoS62 · 2020-09-23T15:00:59Z

has this been tested with ARMC6 compiler? A testprogram with USBMIDI is running on a Bluepill when compiled with gcc, but when I compile it MbedStudio, it produces a hardfault.

masoudr · 2020-09-25T10:51:26Z

I'm having trouble to get it to work with STM32F103RB target. I get no result in my UART port and USBSerial doesn't work either.
mbed_app.json

{
    "macros": [
        "MBED_HEAP_STATS_ENABLED=1",
        "MBED_STACK_STATS_ENABLED=1",
        "MBED_MEM_TRACING_ENABLED=1"
    ],
    "target_overrides": {
        "*": {
            "target.clock_source": "USE_PLL_HSE_EXTC|USE_PLL_HSI",
            "target.macros_add": ["HSE_VALUE=8000000"],
            "target.components_add": [
                "SPIF"
            ],
            "target.device_has_add": ["USBDEVICE"],
            "platform.stdio-baud-rate": 115200,
            "target.stdio_uart_tx": "PB_6",
            "target.stdio_uart_rx": "PB_7"
        }
    }
}

@jeromecoutant Have you tested it with this target?
Thanks.

jeromecoutant · 2020-09-25T14:13:21Z

@jeromecoutant Have you tested it with this target?

Yes... as said in a previous comment:

USB-DP connected to PA12
USB-DM connected to PA11
1.5KOhm pull up to USB-DP PA12
"target.device_has_add": ["USBDEVICE"] in mbed_app.json

jeromecoutant · 2020-09-25T14:14:16Z

and #13522

masoudr · 2020-09-25T15:01:50Z

@jeromecoutant Thanks for the update. I've used the USB6B1 chip but I haven't connected the pull-up resistor. But the code crashes for me. Also, the console doesn't work either to read the details of the exception. Now I will try to add the pull-up resistor and see if it works and report here.

masoudr · 2020-09-25T15:54:55Z

I added the Pull-up resistor and it works fine. I have two questions:

The below code doesn't start (LED won't blink) until I open the USB serial port. Is there any way that I can prevent this?

#include "mbed.h"
#include "USBSerial.h"
//Virtual serial port over USB
USBSerial usbserial;

DebugSerial pc;

DigitalOut LED(PC_8);

bool value = false;

int main(void)
{
    printf("USBSerial test\n");
    while (1) {
        if(usbserial.writable())
            usbserial.printf("I am a virtual serial port\r\n");
        LED  = value;
        value = !value;
        thread_sleep_for(1000);
    }
}

Is there any way that I can use it with a bare-metal profile? I get a linker error for USBSerial class.

{
    "requires": ["bare-metal", "spif-driver", "mbed-trace"],
    "macros": [
        "MBED_HEAP_STATS_ENABLED=1",
        "MBED_STACK_STATS_ENABLED=1",
        "MBED_MEM_TRACING_ENABLED=1"
    ],
    "target_overrides": {
        "*": {
            "target.c_lib": "small",
            "target.printf_lib": "minimal-printf",
            "platform.minimal-printf-enable-floating-point": false,
            "target.clock_source": "USE_PLL_HSE_EXTC|USE_PLL_HSI",
            "target.macros_add": ["HSE_VALUE=8000000"],
            "target.components_add": [
                "SPIF"
            ],
            "target.device_has_add": ["USBDEVICE"]
        }
    }
}

JojoS62 · 2020-09-25T16:06:16Z

you can use USB with bare-metal, just add "drivers-usb" to the requires list.

The USB device classes have defaults in the constructor, the first is 'connect_blocking'.

USBSerial usbserial(false);

but you have to call usbserial.connect() later to connect.

But this should be discussed in the Mbed forum.

wubaojun1982 · 2020-10-31T05:18:44Z

still can't use USBSerial on bluepill (STM32F103C8T6) board.

you need to have the device declared in your custom_target.json:
    "device_has_add": [
        "USBDEVICE"
    ]
the pin map in your custom PeripheralPins.c :

//*** USBDEVICE ***

MBED_WEAK const PinMap PinMap_USB_FS[] = {
{PA_11, USB_FS, STM_PIN_DATA(STM_MODE_INPUT, GPIO_NOPULL, 0)}, // USB_DM
{PA_12, USB_FS, STM_PIN_DATA(STM_MODE_INPUT, GPIO_NOPULL, 0)}, // USB_DP
{NC, NC, 0}
};

and the pin names in the custom PinNames.h
//USB pins
USB_DM = PA_11,
USB_DP = PA_12,

After mbed6.4 released, the USBSerial con't work on bluepill (stm32f103c8t6). All configration don't changed

Allmoz · 2020-10-31T07:47:20Z

Hi,

still can't use USBSerial on bluepill (STM32F103C8T6) board.

you need to have the device declared in your custom_target.json:
    "device_has_add": [
        "USBDEVICE"
    ]
the pin map in your custom PeripheralPins.c :
//*** USBDEVICE ***
MBED_WEAK const PinMap PinMap_USB_FS[] = {
{PA_11, USB_FS, STM_PIN_DATA(STM_MODE_INPUT, GPIO_NOPULL, 0)}, // USB_DM
{PA_12, USB_FS, STM_PIN_DATA(STM_MODE_INPUT, GPIO_NOPULL, 0)}, // USB_DP
{NC, NC, 0}
};
and the pin names in the custom PinNames.h
//USB pins
USB_DM = PA_11,
USB_DP = PA_12,
After mbed6.4 released, the USBSerial con't work on bluepill (stm32f103c8t6). All configration don't changed

Its true for me too, but this should on its own issue. could you make that new issue?

ciarmcom added the release-type: feature label Aug 10, 2020

ciarmcom requested review from jeromecoutant and a team August 10, 2020 15:00

ciarmcom added the needs: review label Aug 10, 2020

jeromecoutant suggested changes Aug 14, 2020

View reviewed changes

mergify bot added the needs: work label Aug 14, 2020

mergify bot removed the needs: review label Aug 14, 2020

Allmoz force-pushed the master branch 2 times, most recently from af73fb5 to a22f3e5 Compare August 14, 2020 18:39

jeromecoutant approved these changes Aug 24, 2020

View reviewed changes

jeromecoutant mentioned this pull request Aug 31, 2020

Changing default serial port conflicts with other serial ports #13510

Closed

0xc0170 previously approved these changes Aug 31, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: work labels Aug 31, 2020

mergify bot added needs: work and removed needs: CI labels Sep 1, 2020

jeromecoutant mentioned this pull request Sep 1, 2020

STM32 USB connect procedure update #13522

Merged

0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Sep 10, 2020

0xc0170 approved these changes Sep 15, 2020

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Sep 15, 2020

0xc0170 merged commit 3801f6e into ARMmbed:master Sep 17, 2020

mergify bot removed the ready for merge label Sep 17, 2020

masoudr mentioned this pull request Sep 25, 2020

Add USBDevice for STM32F103RB with bare-metal profile #13664

Closed

mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020

evedon mentioned this pull request Oct 26, 2020

USB drivers and "events" library added to bare metal profile #13805

Closed

wubaojun1982 mentioned this pull request Nov 1, 2020

USBSerial can't work on bluepill (stm32f1c8t6) after Mbedos 6.4. #13838

Closed

STM32F1 USBDevice #13406

STM32F1 USBDevice #13406

Uh oh!

Conversation

Allmoz commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Best regards

Uh oh!

ciarmcom commented Aug 10, 2020

Uh oh!

adbridge commented Aug 12, 2020

Uh oh!

Allmoz commented Aug 12, 2020

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

jeromecoutant Aug 14, 2020

Choose a reason for hiding this comment

Uh oh!

Allmoz Aug 14, 2020

Choose a reason for hiding this comment

Uh oh!

jeromecoutant commented Aug 14, 2020

Uh oh!

Allmoz commented Aug 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Aug 14, 2020

Uh oh!

Allmoz commented Aug 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Aug 31, 2020

Uh oh!

DesktopMan commented Aug 31, 2020

Uh oh!

jeromecoutant commented Sep 1, 2020

Uh oh!

0xc0170 commented Sep 1, 2020

Uh oh!

mbed-ci commented Sep 1, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

jeromecoutant commented Sep 1, 2020

Jenkins CI Test : ❌ FAILED

Uh oh!

0xc0170 commented Sep 10, 2020

Uh oh!

mbed-ci commented Sep 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Sep 15, 2020

Uh oh!

wubaojun1982 commented Sep 17, 2020

Uh oh!

Allmoz commented Sep 17, 2020

Uh oh!

wubaojun1982 commented Sep 18, 2020

Uh oh!

wubaojun1982 commented Sep 18, 2020

Uh oh!

JojoS62 commented Sep 23, 2020

Uh oh!

masoudr commented Sep 25, 2020

Uh oh!

jeromecoutant commented Sep 25, 2020

Uh oh!

jeromecoutant commented Sep 25, 2020

Uh oh!

masoudr commented Sep 25, 2020

Allmoz commented Aug 10, 2020 •

edited

Loading

Allmoz commented Aug 14, 2020 •

edited

Loading

Allmoz commented Aug 14, 2020 •

edited

Loading

JojoS62 commented Sep 25, 2020 •

edited

Loading