-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix I2C slave bugs on Renesas RZ/A series. #13692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@RyoheiHagimoto, thank you for your changes. |
toyowata
approved these changes
Oct 8, 2020
0xc0170
previously approved these changes
Oct 15, 2020
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@RyoheiHagimoto Please rebase, there is a conflict now on master unfortunately. I'll restart tests once updated and this will get in. |
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
Fixed following I2C slave bugs on Renesas RZ/A series: - Send an incorrect value during slave mode. - The behavior for the restart condition is wrong.
Added the register operation when received the slave address.
e605d04
to
e3fea11
Compare
0xc0170
approved these changes
Oct 26, 2020
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixed following I2C slave bugs on Renesas RZ/A series:
Impact of changes
None.
Changed only i2c_slave functions in targets/TARGET_RENESAS/TARGET_RZ_A?XX/i2c_api.c
Migration actions required
Documentation
Fixed following I2C slave bugs on Renesas RZ/A series:
Pull request type
Test results
Reviewers