Skip to content

Fix I2C slave bugs on Renesas RZ/A series. #13692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

RyoheiHagimoto
Copy link
Contributor

Summary of changes

Fixed following I2C slave bugs on Renesas RZ/A series:

  • Send an incorrect value during slave mode.
  • The behavior for the restart condition is wrong.

Impact of changes

None.
Changed only i2c_slave functions in targets/TARGET_RENESAS/TARGET_RZ_A?XX/i2c_api.c

Migration actions required

Documentation

Fixed following I2C slave bugs on Renesas RZ/A series:

  • Send an incorrect value during slave mode.
  • The behavior for the restart condition is wrong.

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Only local test. Because Greantea does not support I2C Slave functions.

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 1, 2020
@ciarmcom ciarmcom requested review from toyowata and a team October 1, 2020 07:00
@ciarmcom
Copy link
Member

ciarmcom commented Oct 1, 2020

@RyoheiHagimoto, thank you for your changes.
@toyowata @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Oct 15, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Oct 15, 2020
@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 16, 2020

@RyoheiHagimoto Please rebase, there is a conflict now on master unfortunately. I'll restart tests once updated and this will get in.

@mergify
Copy link

mergify bot commented Oct 16, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Fixed following I2C slave bugs on Renesas RZ/A series:
 - Send an incorrect value during slave mode.
 - The behavior for the restart condition is wrong.
Added the register operation when received the slave address.
@mergify mergify bot dismissed 0xc0170’s stale review October 16, 2020 09:02

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 26, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit f9e62fe into ARMmbed:master Oct 27, 2020
@mergify mergify bot removed the ready for merge label Oct 27, 2020
@RyoheiHagimoto RyoheiHagimoto deleted the gr_i2c_slave branch November 9, 2020 01:41
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants