Samsung: fix baremetal #13851 #13853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
approved these changes
Nov 4, 2020
0xc0170
previously requested changes
Nov 4, 2020
There was a problem hiding this comment.
Fixes #13851 issue.
It would be good to have better description in the pull request (adding some info about the bug and how it is fixed). in the description and the commit message. Can you edit the description and also amend the commit message ?
I modified the commit message and the description. |
|
Thanks, one typo in the commit message |
Including unused header file, "cmsis-os.h", causes compile errors. This commit fixes it. Signed-off-by: Heuisam Kwag <[email protected]>
|
CI started |
0xc0170
approved these changes
Nov 4, 2020
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
added
ready for merge
release-type: patch
mbedmain
added
release-version: 6.5.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Heuisam Kwag [email protected]
Summary of changes
Fixes #13851 issue.
Unused header file, "cmsis-os.h", is included in the source.
It causes compile error, this commit fixes it.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@MarceloSalazar