Skip to content

targets: Remove target. prefix from ARM-CM3DS-MPS2 override #14374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2021
Merged

targets: Remove target. prefix from ARM-CM3DS-MPS2 override #14374

merged 1 commit into from
Mar 8, 2021

Conversation

rwalton-arm
Copy link
Contributor

This is the only target in targets.json that uses the target. prefix
when defining a configuration override. This looks like an error, and
causes issues with mbed-tools, so this commit removes the prefix.

Summary of changes

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@rwalton-arm
targets: Remove target. prefix from ARM-CM3DS-MPS2 override
905fc25 
This is the only target in targets.json that uses the `target.` prefix
when defining a configuration override. This looks like an error, and
causes issues with mbed-tools, so this commit removes the prefix.
@mergify mergify bot added the needs: CI label Mar 3, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 4, 2021

CI started

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Mar 4, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Mar 5, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Mar 5, 2021

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 5, 2021

CI restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 5, 2021

It looks like there is an error. I wonder if this is on master again or just this one

[2021-03-05T14:28:42.338Z] Previous HEAD position was 8a1ce92317 Merge pull request #14368 from LDong-Arm/minimal_printf_cmake_fix

[2021-03-05T14:28:42.338Z] Switched to branch 'mbed-os-ci-test-unique-id'

[2021-03-05T14:28:42.600Z] multiprocessing.pool.RemoteTraceback: 

[2021-03-05T14:28:42.600Z] """

[2021-03-05T14:28:42.600Z] Traceback (most recent call last):

[2021-03-05T14:28:42.600Z]   File "/usr/lib/python3.6/multiprocessing/pool.py", line 119, in worker

[2021-03-05T14:28:42.600Z]     result = (True, func(*args, **kwds))

[2021-03-05T14:28:42.600Z]   File "/usr/lib/python3.6/multiprocessing/pool.py", line 44, in mapstar

[2021-03-05T14:28:42.600Z]     return list(map(*args))

[2021-03-05T14:28:42.600Z]   File "smart-tester/target_toolchain_selector.py", line 92, in get_resources_filenames_target_toolchains

[2021-03-05T14:28:42.600Z]     resources_filenames_target_toolchains[target][toolchain] = get_resources_filenames(".", target, toolchain)

[2021-03-05T14:28:42.600Z]   File "smart-tester/target_toolchain_selector.py", line 32, in get_resources_filenames

[2021-03-05T14:28:42.600Z]     notify=MockNotifier())

[2021-03-05T14:28:42.600Z]   File "./tools/build_api.py", line 514, in prepare_toolchain

[2021-03-05T14:28:42.600Z]     target, notify, macros, build_dir=build_dir, build_profile=profile, coverage_patterns=coverage_patterns)

[2021-03-05T14:28:42.600Z]   File "./tools/toolchains/iar.py", line 64, in __init__

[2021-03-05T14:28:42.600Z]     self.check_c_lib_supported(target, "iar")

[2021-03-05T14:28:42.600Z]   File "./tools/toolchains/mbed_toolchain.py", line 1113, in check_c_lib_supported

[2021-03-05T14:28:42.600Z]     UNSUPPORTED_C_LIB_EXCEPTION_STRING.format(target.c_lib)

[2021-03-05T14:28:42.600Z] tools.

@rwalton-arm
Copy link
Contributor Author

It looks like there is an error. I wonder if this is on master again or just this one

[2021-03-05T14:28:42.338Z] Previous HEAD position was 8a1ce92317 Merge pull request #14368 from LDong-Arm/minimal_printf_cmake_fix

[2021-03-05T14:28:42.338Z] Switched to branch 'mbed-os-ci-test-unique-id'

[2021-03-05T14:28:42.600Z] multiprocessing.pool.RemoteTraceback: 

[2021-03-05T14:28:42.600Z] """

[2021-03-05T14:28:42.600Z] Traceback (most recent call last):

[2021-03-05T14:28:42.600Z]   File "/usr/lib/python3.6/multiprocessing/pool.py", line 119, in worker

[2021-03-05T14:28:42.600Z]     result = (True, func(*args, **kwds))

[2021-03-05T14:28:42.600Z]   File "/usr/lib/python3.6/multiprocessing/pool.py", line 44, in mapstar

[2021-03-05T14:28:42.600Z]     return list(map(*args))

[2021-03-05T14:28:42.600Z]   File "smart-tester/target_toolchain_selector.py", line 92, in get_resources_filenames_target_toolchains

[2021-03-05T14:28:42.600Z]     resources_filenames_target_toolchains[target][toolchain] = get_resources_filenames(".", target, toolchain)

[2021-03-05T14:28:42.600Z]   File "smart-tester/target_toolchain_selector.py", line 32, in get_resources_filenames

[2021-03-05T14:28:42.600Z]     notify=MockNotifier())

[2021-03-05T14:28:42.600Z]   File "./tools/build_api.py", line 514, in prepare_toolchain

[2021-03-05T14:28:42.600Z]     target, notify, macros, build_dir=build_dir, build_profile=profile, coverage_patterns=coverage_patterns)

[2021-03-05T14:28:42.600Z]   File "./tools/toolchains/iar.py", line 64, in __init__

[2021-03-05T14:28:42.600Z]     self.check_c_lib_supported(target, "iar")

[2021-03-05T14:28:42.600Z]   File "./tools/toolchains/mbed_toolchain.py", line 1113, in check_c_lib_supported

[2021-03-05T14:28:42.600Z]     UNSUPPORTED_C_LIB_EXCEPTION_STRING.format(target.c_lib)

[2021-03-05T14:28:42.600Z] tools.

Doesn't look related to the change I've made here. Is this an intermittent issue?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2021

Yes, master was broken. It should be OK now, CI restarted

@mbed-ci
Copy link

mbed-ci commented Mar 8, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 31a60a9 into ARMmbed:master Mar 8, 2021
@mergify mergify bot removed ready for merge stale Stale Pull Request labels Mar 8, 2021
@dependabot dependabot bot mentioned this pull request Mar 9, 2021
Closed
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rwalton-arm @0xc0170 @ciarmcom @mbed-ci @mbedmain