minor clean up: finishChannel

Author: Stephane Landelle

src/main/java/com/ning/http/client/providers/netty/NettyAsyncHttpProvider.java

@@ -1024,23 +1024,19 @@ private void closeChannel(final ChannelHandlerContext ctx) {
     private void finishChannel(final ChannelHandlerContext ctx) {
         ctx.setAttachment(DiscardEvent.INSTANCE);
 
-        // The channel may have already been removed if a timeout occurred, and this method may be called just after.
-        if (ctx.getChannel() == null) {
-            return;
-        }
-
-        LOGGER.debug("Closing Channel {} ", ctx.getChannel());
-
-        try {
-            ctx.getChannel().close();
-        } catch (Throwable t) {
-            LOGGER.debug("Error closing a connection", t);
-        }
+        Channel channel = ctx.getChannel();
 
-        if (ctx.getChannel() != null) {
-            openChannels.remove(ctx.getChannel());
+        // The channel may have already been removed if a timeout occurred, and this method may be called just after.
+        if (channel != null) {
+            // FIXME can the context channel really be null?
+            LOGGER.debug("Closing Channel {} ", ctx.getChannel());
+            try {
+                channel.close();
+            } catch (Throwable t) {
+                LOGGER.debug("Error closing a connection", t);
+            }
+            openChannels.remove(channel);
         }
-
     }
 
     @Override