Don't use FileOutputStream that creates Finalizers

Author: slandelle

client/src/main/java/org/asynchttpclient/handler/BodyDeferringAsyncHandler.java

@@ -46,7 +46,7 @@
  * handling than "recommended" way. Some examples:
  * <br>
  * <pre>
- *     FileOutputStream fos = ...
+ *     OutputStream fos = ...
  *     BodyDeferringAsyncHandler bdah = new BodyDeferringAsyncHandler(fos);
  *     // client executes async
  *     Future&lt;Response&gt; fr = client.prepareGet(&quot;http://foo.com/aresource&quot;).execute(

client/src/main/java/org/asynchttpclient/handler/resumable/PropertiesBasedResumableProcessor.java

@@ -12,12 +12,13 @@
  */
 package org.asynchttpclient.handler.resumable;
 
-import static java.nio.charset.StandardCharsets.*;
+import static java.nio.charset.StandardCharsets.UTF_8;
 import static org.asynchttpclient.util.MiscUtils.closeSilently;
 
 import java.io.File;
 import java.io.FileNotFoundException;
-import java.io.FileOutputStream;
+import java.io.OutputStream;
+import java.nio.file.Files;
 import java.util.Map;
 import java.util.Scanner;
 import java.util.concurrent.ConcurrentHashMap;
@@ -59,7 +60,7 @@ public void remove(String uri) {
     @Override
     public void save(Map<String, Long> map) {
         log.debug("Saving current download state {}", properties.toString());
-        FileOutputStream os = null;
+        OutputStream os = null;
         try {
 
             if (!TMP.exists() && !TMP.mkdirs()) {
@@ -73,17 +74,15 @@ public void save(Map<String, Long> map) {
                 throw new IllegalStateException();
             }
 
-            os = new FileOutputStream(f);
-
+            os = Files.newOutputStream(f.toPath());
             for (Map.Entry<String, Long> e : properties.entrySet()) {
                 os.write(append(e).getBytes(UTF_8));
             }
             os.flush();
         } catch (Throwable e) {
             log.warn(e.getMessage(), e);
         } finally {
-            if (os != null)
-                closeSilently(os);
+            closeSilently(os);
         }
     }
 

client/src/test/java/org/asynchttpclient/request/body/ZeroCopyFileTest.java

@@ -12,14 +12,15 @@
  */
 package org.asynchttpclient.request.body;
 
-import static org.asynchttpclient.Dsl.*;
+import static org.asynchttpclient.Dsl.asyncHttpClient;
 import static org.asynchttpclient.test.TestUtils.*;
 import static org.testng.Assert.*;
 
 import java.io.File;
-import java.io.FileOutputStream;
 import java.io.IOException;
+import java.io.OutputStream;
 import java.net.URISyntaxException;
+import java.nio.file.Files;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Future;
 import java.util.concurrent.TimeoutException;
@@ -117,7 +118,7 @@ public void zeroCopyFileTest() throws IOException, ExecutionException, TimeoutEx
         File tmp = new File(System.getProperty("java.io.tmpdir") + File.separator + "zeroCopy.txt");
         tmp.deleteOnExit();
         try (AsyncHttpClient client = asyncHttpClient()) {
-            try (FileOutputStream stream = new FileOutputStream(tmp)) {
+            try (OutputStream stream = Files.newOutputStream(tmp.toPath())) {
                 Response resp = client.preparePost("http://localhost:" + port1 + "/").setBody(SIMPLE_TEXT_FILE).execute(new AsyncHandler<Response>() {
                     public void onThrowable(Throwable t) {
                     }
@@ -150,7 +151,7 @@ public void zeroCopyFileWithBodyManipulationTest() throws IOException, Execution
         File tmp = new File(System.getProperty("java.io.tmpdir") + File.separator + "zeroCopy.txt");
         tmp.deleteOnExit();
         try (AsyncHttpClient client = asyncHttpClient()) {
-            try (FileOutputStream stream = new FileOutputStream(tmp)) {
+            try (OutputStream stream = Files.newOutputStream(tmp.toPath())) {
                 Response resp = client.preparePost("http://localhost:" + port1 + "/").setBody(SIMPLE_TEXT_FILE).execute(new AsyncHandler<Response>() {
                     public void onThrowable(Throwable t) {
                     }

client/src/test/java/org/asynchttpclient/request/body/multipart/MultipartUploadTest.java

@@ -20,7 +20,6 @@
 import java.io.ByteArrayOutputStream;
 import java.io.File;
 import java.io.FileNotFoundException;
-import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
@@ -130,7 +129,7 @@ public void testSendingSmallFilesAndByteArray() throws IOException {
 
         boolean tmpFileCreated = false;
         File tmpFile = File.createTempFile("textbytearray", ".txt");
-        try (FileOutputStream os = new FileOutputStream(tmpFile)) {
+        try (OutputStream os = Files.newOutputStream(tmpFile.toPath())) {
             IOUtils.write(expectedContents.getBytes(UTF_8), os);
             tmpFileCreated = true;
 
@@ -349,7 +348,7 @@ public void service(HttpServletRequest request, HttpServletResponse response) th
                                 // Process the input stream
                                 File tmpFile = File.createTempFile(UUID.randomUUID().toString() + "_MockUploadServlet", ".tmp");
                                 tmpFile.deleteOnExit();
-                                try (OutputStream os = new FileOutputStream(tmpFile)) {
+                                try (OutputStream os = Files.newOutputStream(tmpFile.toPath())) {
                                     byte[] buffer = new byte[4096];
                                     int bytesRead;
                                     while ((bytesRead = stream.read(buffer)) != -1) {

client/src/test/java/org/asynchttpclient/test/TestUtils.java

@@ -18,15 +18,16 @@
 
 import java.io.File;
 import java.io.FileNotFoundException;
-import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.OutputStream;
 import java.net.ServerSocket;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
 import java.nio.ByteBuffer;
 import java.nio.charset.Charset;
+import java.nio.file.Files;
 import java.security.GeneralSecurityException;
 import java.security.KeyStore;
 import java.security.SecureRandom;
@@ -137,7 +138,7 @@ public static File createTempFile(int approxSize) throws IOException {
         long repeats = approxSize / TestUtils.PATTERN_BYTES.length + 1;
         File tmpFile = File.createTempFile("tmpfile-", ".data", TMP_DIR);
         tmpFile.deleteOnExit();
-        try (FileOutputStream out = new FileOutputStream(tmpFile)) {
+        try (OutputStream out = Files.newOutputStream(tmpFile.toPath())) {
             for (int i = 0; i < repeats; i++) {
                 out.write(PATTERN_BYTES);
             }