Update progress during upload #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you please update your commit message to match this template? |
Motivation: org.asynchttpclient.netty.request.body.BodyChunkedInput does not update progress member, it stays zero whole time. Thus org.asynchttpclient.handler.onContentWriteProgress#onContentWriteProgress receives zeroes in ammount and current parameters. Users sees data is being sent but has no information about exact amount of data has been written to channel. Modifications: org.asynchttpclient.netty.request.body.BodyChunkedInput was modified to update progress. org.asynchttpclient.netty.request.WriteProgressListener was modified to ignore zero progress. It happens due to non-blocking nature of network writes. We just ignore callbacks when there was no progress at all. Result: Progress is updated each time bytes are phisically written to channel. Callbacks are triggered with actual amount of data written.
|
Done. Please check |
|
Awesome, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #728