Fix broken Head302Test #1421
Merged
Fix broken Head302Test #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test had the following defects which caused it to falsely pass: * Jetty requires a handler to explicitly indicate it has handled the request by calling Request.setHandled(true). Otherwise the server will return 404. * The test did not configure the client to follow redirects. * The test itself wasn't asserting anything useful beyond that the request did not time out. To ensure the redirect was followed, it needs to assert the expected response status code from the redirected location is received.
The test now verifies that a HEAD redirected via 302 is switched to GET per [1]. [1] #989
|
The Travis build failure appears to be related to #1380: |
|
Thanks a lot!
Yep. It takes hundreds of cycles on my machine to reproduce. I guess I would have to run on a small Docker container so I can investigate, and I don't have time for that atm, even though this one gets me nuts... The issue could be anywhere: JDK, Netty, AHC, netty-reactive-streams, Jetty, rx-java... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was originally going to report a bug that my HEAD requests were being switched to GET upon a 301 redirect. Then I came across #989 and learned that this behavior is by design. 😄
However, before I discovered that issue, I was playing around with
Head302Testbecause it seemed to confirm my impression that the HEAD method should be preserved upon a redirect. It was at this time that I discovered this test was falsely passing.I first updated the test to demonstrate that it actually fails. Then I modified it to conform to the behavior described in #989 so that it now passes. This PR captures both of these changes.