Skip to content

Add suspend-resume support for durable client #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 12, 2024
Merged

Conversation

nytian
Copy link
Contributor

@nytian nytian commented Jan 31, 2024

As titled.

@nytian nytian requested a review from davidmrdavid January 31, 2024 20:35
@nytian
Copy link
Contributor Author

nytian commented Jan 31, 2024

I didn't add the resume test yet since for the resume e2e test, I think we need 4 responses back:
1.orchestration has been initialized, 2. orchestration is running, 3. orchestration is suspended, 4. orchestration is resumed. And it seems like ValidateDurableWorkflowResults can have 3 responses check in max.

But I think it's better not edit the method ValidateDurableWorkflowResults considering lots of tests using this. My idea now is that starting an orchestrator can't be finished, like listening to an external event which will never be sent, and then calling suspend, waiting for 3 sec to make sure it's suspended, calling resume, check if it's back to running? Appreciate your thoughts about this test. Thank you! @davidmrdavid

@davidmrdavid
Copy link
Collaborator

I didn't add the resume test yet since for the resume e2e test, I think we need 4 responses back:
1.orchestration has been initialized, 2. orchestration is running, 3. orchestration is suspended, 4. orchestration is resumed. And it seems like ValidateDurableWorkflowResults can have 3 responses check in max.

Not sure I follow this. Let's sync on this tomorrow

@nytian nytian marked this pull request as draft February 9, 2024 02:50
@nytian nytian marked this pull request as ready for review February 9, 2024 18:18
@nytian nytian merged commit 2e15342 into main Feb 12, 2024
@nytian nytian deleted the nytian/enable_suspend branch February 12, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants