Skip to content

Make the binding-info dictionary case-insensitive on the key (binding name) #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2019

Conversation

daxian-dbw
Copy link
Contributor

Make the binding-info dictionary case-insensitive on the key (binding name).

When testing the bindings in our priority list, I found currently Push-OutputBinding treat the output binding name case-sensitively.
If the output binding name in function.json is outblob, then Push-OutputBinding -Name outBlob will fail. This PR fixes that issue.

TylerLeonhardt
TylerLeonhardt previously approved these changes Apr 3, 2019
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TylerLeonhardt
Copy link
Member

Looks like CI failed :(

@daxian-dbw
Copy link
Contributor Author

CI fixed. It's because of the Hashtable case-sensitive issue, which has been addressed in PowerShell/PowerShell#8566

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit be09670 into Azure:dev Apr 3, 2019
@daxian-dbw daxian-dbw deleted the fixcase branch April 3, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants