Rename DF components #793
Merged
Rename DF components #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo remove TODOs remove commented-out code
AnatoliB
reviewed
Apr 15, 2022
AnatoliB
reviewed
Apr 15, 2022
AnatoliB
approved these changes
Apr 15, 2022
…hell-worker into dajusto/rename-df-components
davidmrdavid
added a commit
that referenced
this pull request
Sep 7, 2022
davidmrdavid
added a commit
that referenced
this pull request
Sep 7, 2022
This was referenced Sep 7, 2022
davidmrdavid
added a commit
that referenced
this pull request
Sep 7, 2022
davidmrdavid
added a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
This PR contains some of the changes originally proposed in #746
This PR introduces two non-behavioral changes (i.e the end-user should not be affected in any way):
Durabledirectory in the worker has been split into two folders:DurableSDKandDurableWorker. The former represents the SDK-specific components that, in the future, could be removed from this repo; this means it also represents the SDK-components that ought to exist in the external SDK. Meanwhile, theDurableWorkerdirectory represents DF logic that is intrinsic to the worker, and ought to stay in this repo.DurableSDKdirectory in particular is meant to be "drag and dropped" into an external SDK implementation; it's self-contained. As a result, we have removed any coupling of files within it with utility classes elsewhere in the repo. In practice, this means a few function definitions have been "duplicated" so that they now exist independently inside the "DurableSDK" directory. This is fine since we plan to eventually remove theDurableSDKrepo from the worker.In other words, I'm just slightly re-organizing the codebase to set the stage for the external SDK work. I decided to make this its own separate PR because a lot of files are affected and yet no functionality is changed, so I wanted to make sure this did not distract from the future PR where we actually change some behavior to enable the external DF SDK.
Pull request checklist
release_notes.mdAdditional information
This needs to be backported to all DF-supported branches.
co-authored to an equal extent with @michaelpeng36