Skip to content

Populate language worker metadata in init response #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 5, 2022
Merged

Populate language worker metadata in init response #884

merged 5 commits into from
Nov 5, 2022

Conversation

Francisco-Gamino
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino commented Oct 27, 2022 •
edited
Loading

Issue describing the changes in this PR

This PR contains the following change:

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@Francisco-Gamino
Copy link
Contributor Author

Francisco-Gamino commented Oct 27, 2022 •
edited
Loading

@AnatoliB / @michaelpeng36 -- Could you please take a look?
Please note that we will continue to defer the worker initialization to the first FunctionLoadRequest for the placeholder scenario. Also, during the first FunctionLoadRequest that's when we know if Managed Dependencies (MD) is enabled for the app, and if it is, we will add the MD path to the PSModulePath.

ejizba
ejizba reviewed Oct 27, 2022
View reviewed changes
Copy link

@ejizba ejizba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we perform some logic in the worker init request as well, so I have some knowledge on a few scenarios that may cause you headaches

AnatoliB
AnatoliB reviewed Nov 2, 2022
View reviewed changes
michaelpeng36
michaelpeng36 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@michaelpeng36 michaelpeng36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment, otherwise LGTM

AnatoliB
AnatoliB approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@AnatoliB AnatoliB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco-Gamino Francisco-Gamino merged commit c4fe842 into dev Nov 5, 2022
Francisco-Gamino added a commit that referenced this pull request Sep 10, 2023
@Francisco-Gamino
Populate language worker metadata in init response (#884)
673a390 
* Populate language worker metadata

* Continue to defer the worker initialization until the first FunctionLoadRequest
Francisco-Gamino added a commit that referenced this pull request Sep 10, 2023
@Francisco-Gamino
Populate language worker metadata in init response (#884)
f77dea5 
* Populate language worker metadata

* Continue to defer the worker initialization until the first FunctionLoadRequest
@Francisco-Gamino Francisco-Gamino mentioned this pull request Sep 10, 2023
Merged
7 tasks
Francisco-Gamino added a commit that referenced this pull request Sep 11, 2023
@Francisco-Gamino
Update language worker to support parsing command-line arguments pref…
c956de4 
…ix with functions-<argumentname> (#997)

* Update language worker to support parsing command-line arguments prefix with functions-<argumentname> (#993)

* Populate language worker metadata in init response (#884) 

* Updated subtree from https://github.com/azure/azure-functions-language-worker-protobuf. Tag: v1.5.8-protofile. Commit: 14b2ba5ccb188c160c0f6c519ec1d4521ee36440 (#876)
@Francisco-Gamino Francisco-Gamino deleted the Francisco-Gamino/add-worker-metadata-1 branch September 11, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejizba ejizba ejizba left review comments

@AnatoliB AnatoliB AnatoliB approved these changes

@michaelpeng36 michaelpeng36 michaelpeng36 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Populate WorkerMetadata in WorkerInitResponse message
4 participants
@Francisco-Gamino @ejizba @AnatoliB @michaelpeng36