-
Notifications
You must be signed in to change notification settings - Fork 69
Python Worker Extension Interface (sdk) #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Result of Pytest Coverage |
1 similar comment
✅ Result of Pytest Coverage |
Fix nit Ensure extension can be loaded successfully Add unittests Modify documentations Change trace context attribute names Fix wrongly declared abstract method Accept Revert changes in Context Fix unittests
50361a9
to
e0811a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First set comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully, last set of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚢
Background Story
This PR is used for building up an interface to integrate OpenCensus into Azure Functions without the need of modifying customer's code.
The reason why we want to pull this out is to ensure the invocation flow follows:
Python Worker => Python Library => Extension => Customer's Code
Design Doc
PR should be here: Azure/azure-functions-python-worker#815
Internal design: doc
Example
AppExtension: https://github.com/Hazhzeng/application-ext-timer
FuncExtension: https://github.com/Hazhzeng/functions-ext-profile
Next Step
This is the first PR to be in this series:
After merging this PR, we can continue on the worker side PR
Azure/azure-functions-python-worker#757
cc: @lzchen