Skip to content

Python Worker Extension Interface (sdk) #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 19, 2021
Merged

Python Worker Extension Interface (sdk) #81

merged 17 commits into from
Mar 19, 2021

Conversation

Hazhzeng
Copy link
Contributor

@Hazhzeng Hazhzeng commented Feb 3, 2021

Background Story

This PR is used for building up an interface to integrate OpenCensus into Azure Functions without the need of modifying customer's code.

The reason why we want to pull this out is to ensure the invocation flow follows:
Python Worker => Python Library => Extension => Customer's Code

Design Doc

PR should be here: Azure/azure-functions-python-worker#815
Internal design: doc

Example

AppExtension: https://github.com/Hazhzeng/application-ext-timer
FuncExtension: https://github.com/Hazhzeng/functions-ext-profile

Next Step

This is the first PR to be in this series:
After merging this PR, we can continue on the worker side PR
Azure/azure-functions-python-worker#757

cc: @lzchen

@Hazhzeng Hazhzeng marked this pull request as draft February 3, 2021 05:27
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

✅ Result of Pytest Coverage

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

✅ Result of Pytest Coverage

Fix nit

Ensure extension can be loaded successfully

Add unittests

Modify documentations

Change trace context attribute names

Fix wrongly declared abstract method

Accept

Revert changes in Context

Fix unittests
@Hazhzeng Hazhzeng changed the title Added interface for extension registration Python Worker Extension Interface (SDK) Mar 6, 2021
@Hazhzeng Hazhzeng changed the title Python Worker Extension Interface (SDK) Python Worker Extension Interface (sdk) Mar 6, 2021
@vrdmr vrdmr requested a review from AnatoliB March 15, 2021 18:10
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set comments.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, last set of comments.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

@Hazhzeng Hazhzeng merged commit 51520e6 into dev Mar 19, 2021
@Hazhzeng Hazhzeng deleted the hazeng/extension branch March 19, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants