Address comments

Author: Gavin Aguiar

azure_functions_worker/extension.py

@@ -65,7 +65,7 @@ def function_load_extension(cls, func_name, func_directory):
         sdk = cls._try_get_sdk_with_extension_enabled()
         if sdk is None:
             return
-        logger.info("Sdk path: %s", sdk.__file__)
+
         # Reports application & function extensions installed on customer's app
         cls._info_discover_extension_list(func_name, sdk)
 
@@ -236,9 +236,8 @@ def _try_get_sdk_with_extension_enabled(cls) -> Optional[ModuleType]:
     @classmethod
     def _info_extension_is_enabled(cls, sdk):
         logger.info(
-            'Python Worker Extension is enabled in azure.functions (%s).',
-            get_sdk_version(sdk)
-        )
+            'Python Worker Extension is enabled in azure.functions (%s). '
+            'Sdk path: %s', get_sdk_version(sdk), sdk.__file__)
 
     @classmethod
     def _info_discover_extension_list(cls, function_name, sdk):

tests/unittests/test_dispatcher.py

@@ -44,6 +44,7 @@ def setUp(self, version=SysVersionInfo(3, 7, 0, 'final', 0)):
             script_root=DISPATCHER_FUNCTIONS_DIR)
         self._default_workers: Optional[
             int] = PYTHON_THREADPOOL_THREAD_COUNT_DEFAULT
+        self._over_max_workers: int = 10000
         self._allowed_max_workers: int = PYTHON_THREADPOOL_THREAD_COUNT_MAX_37
         self._pre_env = dict(os.environ)
         self.mock_version_info = patch(
@@ -451,7 +452,6 @@ async def _check_if_async_function_is_ok(self, host) -> Tuple[str, str]:
 class TestThreadPoolSettingsPython38(TestThreadPoolSettingsPython37):
     def setUp(self, version=SysVersionInfo(3, 8, 0, 'final', 0)):
         super(TestThreadPoolSettingsPython38, self).setUp(version)
-        self._over_max_workers: int = 10000
         self._allowed_max_workers: int = self._over_max_workers
 
     def tearDown(self):

tests/unittests/test_extension.py

@@ -57,6 +57,7 @@ def setUp(self):
             'resources',
             'mock_azure_functions'
         )
+        self._dummy_sdk = Mock(__file__="test")
 
         # Initialize mock context
         self._mock_arguments = {'req': 'request'}
@@ -113,7 +114,8 @@ def test_extension_if_sdk_not_in_path(self):
         sdk_enabled = self._instance._is_extension_enabled_in_sdk(module)
         self.assertTrue(sdk_enabled)
 
-    @patch('azure_functions_worker.extension.get_sdk_from_sys_path')
+    @patch('azure_functions_worker.extension.get_sdk_from_sys_path',
+           return_value=importlib.import_module('azure.functions'))
     def test_function_load_extension_enable_when_feature_flag_is_on(
         self,
         get_sdk_from_sys_path_mock: Mock
@@ -185,7 +187,8 @@ def test_function_load_extension_should_invoke_extension_call(
             any_order=True
         )
 
-    @patch('azure_functions_worker.extension.get_sdk_from_sys_path')
+    @patch('azure_functions_worker.extension.get_sdk_from_sys_path',
+           return_value=importlib.import_module('azure.functions'))
     def test_invocation_extension_enable_when_feature_flag_is_on(
         self,
         get_sdk_from_sys_path_mock: Mock
@@ -719,7 +722,7 @@ def test_info_extension_is_enabled(self, info_mock: Mock):
         self._instance._info_extension_is_enabled(sdk)
         info_mock.assert_called_once_with(
             'Python Worker Extension is enabled in azure.functions '
-            '(%s).', sdk.__version__
+            '(%s). Sdk path: %s', sdk.__version__, sdk.__file__
         )
 
     @patch('azure_functions_worker.extension.logger.info')

tests/unittests/test_utilities.py

@@ -364,6 +364,7 @@ def test_get_sdk_dummy_version(self):
         module = common.get_sdk_from_sys_path()
         sdk_version = common.get_sdk_version(module)
         self.assertNotEqual(sdk_version, 'dummy')
+
     def test_get_sdk_dummy_version_with_flag_enabled(self):
         """Test if sdk version can get dummy sdk version
         """