Skip to content

Disable dependency isolation for py 3.10 #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Disable dependency isolation for py 3.10 #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b86e64b
Disable dependency isolation for py 3.10
gavin-aguiar Apr 8, 2022
a68928b
Fixing unit tests
gavin-aguiar Apr 8, 2022
7803694
Merge branch 'dev' into gaaguiar/disable_dep_iso
vrdmr Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure_functions_worker/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
PYTHON_THREADPOOL_THREAD_COUNT_MAX_37 = 32

PYTHON_ISOLATE_WORKER_DEPENDENCIES_DEFAULT = False
PYTHON_ISOLATE_WORKER_DEPENDENCIES_DEFAULT_310 = True
PYTHON_ISOLATE_WORKER_DEPENDENCIES_DEFAULT_310 = False
PYTHON_ENABLE_WORKER_EXTENSIONS_DEFAULT = False
PYTHON_ENABLE_WORKER_EXTENSIONS_DEFAULT_39 = True

Expand Down
10 changes: 4 additions & 6 deletions tests/unittests/test_utilities_dependency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,10 +571,8 @@ def test_use_worker_dependencies_default_python_36_37_38_39(self):
with self.assertRaises(ImportError):
import common_module # NoQA

@unittest.skipUnless(
is_python_version('3.10'),
'Test only available for python 3.10'
)
@unittest.skip('Skipping since PYTHON_ISOLATE_WORKER_DEPENDENCIES is '
'disabled by default')
def test_use_worker_dependencies_default_python_310(self):
# Feature should be enabled in Python 3.10 by default
# Setup paths
Expand Down Expand Up @@ -642,8 +640,8 @@ def test_prioritize_customer_dependencies_default_python_36_37_38_39(self):
with self.assertRaises(ImportError):
import common_module # NoQA

@unittest.skipUnless(is_python_version('3.10'),
'Test only available for python 3.10')
@unittest.skip('Skipping since PYTHON_ISOLATE_WORKER_DEPENDENCIES is '
'disabled by default')
def test_prioritize_customer_dependencies_default_python_310(self):
# Feature should be enabled in Python 3.10 by default
# Setup paths
Expand Down