Correct type annotation for build_binding_protos() #1040
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaloney
requested review from
vrdmr,
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #1040 +/- ##
=======================================
Coverage 83.46% 83.46%
=======================================
Files 33 33
Lines 1778 1778
Branches 282 282
=======================================
Hits 1484 1484
Misses 230 230
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vrdmr
approved these changes
Jun 7, 2022
|
Closing this PR as the typing 'Function' was removed #1046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is not expecting a list.