From 1d8b5578dbd5754cc549a9b106148393e7495ce1 Mon Sep 17 00:00:00 2001 From: Gavin Aguiar Date: Mon, 1 May 2023 20:59:06 -0500 Subject: [PATCH 1/2] Logging improvements --- azure_functions_worker/dispatcher.py | 2 ++ azure_functions_worker/utils/dependency.py | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/azure_functions_worker/dispatcher.py b/azure_functions_worker/dispatcher.py index d05d18392..2d5543d28 100644 --- a/azure_functions_worker/dispatcher.py +++ b/azure_functions_worker/dispatcher.py @@ -290,6 +290,8 @@ async def _handle__worker_init_request(self, request): if DependencyManager.is_in_linux_consumption() \ and is_envvar_true(PYTHON_LOAD_FUNCTIONS_INIT): + logger.info( + "PYTHON_LOAD_FUNCTIONS_INIT enabled. Importing azure functions") import azure.functions # NoQA # loading bindings registry and saving results to a static diff --git a/azure_functions_worker/utils/dependency.py b/azure_functions_worker/utils/dependency.py index 08ac7da50..b0038c695 100644 --- a/azure_functions_worker/utils/dependency.py +++ b/azure_functions_worker/utils/dependency.py @@ -210,17 +210,17 @@ def reload_azure_google_namespace_from_worker_deps(cls): """ # Reload package namespaces for customer's libraries packages_to_reload = ['azure', 'google'] + packages_reloaded = [] for p in packages_to_reload: try: - logger.info('Reloading %s module', p) importlib.reload(sys.modules[p]) + packages_reloaded.append(p) except Exception as ex: logger.info('Unable to reload %s: \n%s', p, ex) - logger.info('Reloaded %s module', p) + + logger.info(f'Reloaded modules: {",".join(packages_reloaded)}') # Reload azure.functions to give user package precedence - logger.info('Reloading azure.functions module at %s', - inspect.getfile(sys.modules['azure.functions'])) try: importlib.reload(sys.modules['azure.functions']) logger.info('Reloaded azure.functions module now at %s', From 4a51f911632bcc3072402a1dbeb62f8f71941802 Mon Sep 17 00:00:00 2001 From: Gavin Aguiar Date: Tue, 2 May 2023 15:30:22 -0500 Subject: [PATCH 2/2] Update logging info to warning --- azure_functions_worker/utils/dependency.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure_functions_worker/utils/dependency.py b/azure_functions_worker/utils/dependency.py index b0038c695..9a8d75bd4 100644 --- a/azure_functions_worker/utils/dependency.py +++ b/azure_functions_worker/utils/dependency.py @@ -216,7 +216,7 @@ def reload_azure_google_namespace_from_worker_deps(cls): importlib.reload(sys.modules[p]) packages_reloaded.append(p) except Exception as ex: - logger.info('Unable to reload %s: \n%s', p, ex) + logger.warning('Unable to reload %s: \n%s', p, ex) logger.info(f'Reloaded modules: {",".join(packages_reloaded)}')