Update proto and add custom build steps #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiqbal11
force-pushed
the
update-proto
branch
from
828ee6a to
e35d9e2
Compare
Hazhzeng
reviewed
Jan 7, 2020
setup.py
Outdated
Comment on lines
84
to
88
| if os.path.exists(staging_root_dir): | ||
| shutil.rmtree(build_dir) | ||
|
|
||
| if os.path.exists(built_protos_dir): | ||
| shutil.rmtree(built_protos_dir) |
There was a problem hiding this comment.
Seems like these four lines can be combined together?
if os.path.exists(build_dir):
shutil.rmtree(build_dir)Am I missing something here?
| shutil.rmtree(build_dir) | ||
|
|
||
| if os.path.exists(built_protos_dir): | ||
| shutil.rmtree(built_protos_dir) | ||
|
|
||
| proto_files = glob.glob(str(proto_src_dir / '**' / '*.proto'), | ||
| recursive=True) | ||
| shutil.copytree(proto_src_dir, staging_dir) |
There was a problem hiding this comment.
Doesn't seems like staging_dir is used anywhere else. Maybe we can remove it?
There was a problem hiding this comment.
It's being used to do the copying as you pointed here. In the actual build command, we are using the same directory structure without explicitly referencing the staging_dir. Might be useful to walk through this offline as it's slightly tedious to explain here.
Hazhzeng
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to unblock #554. Contains the same logic as #528 which was reverted.