Skip to content

Make our worker code backward compatible with protobuf<3.8.0 #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

Hazhzeng
Copy link
Contributor

@Hazhzeng Hazhzeng commented Jul 14, 2020

Description

Fixes the rest of the dispatcher not found issue.
Azure Functions Python Worker is using a Protobuf version of 3.12
Customer could break our worker code by brining a Protobuf package < 3.8.0
Issue Protobuf < 3.8.0: protocolbuffers/protobuf#6028
Fix released Protobuf >= 3.8.0: protocolbuffers/protobuf@0de6577
image

We should use the backward compatible syntax in worker RpcLogCategory.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants