Skip to content

Reverting #745 to limit Debug logs #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2020
Merged

Reverting #745 to limit Debug logs #780

merged 2 commits into from
Nov 10, 2020

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Nov 10, 2020

Description

#745 introduced a regression as the host currently cannot handle apps with high rate of debug logs being sent to it. This PR reverts that change.

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Hazhzeng
Hazhzeng approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@Hazhzeng Hazhzeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@vrdmr vrdmr merged commit d76ff60 into dev Nov 10, 2020
@vrdmr vrdmr deleted the vameru/revert-debug-to-info branch November 10, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hazhzeng Hazhzeng Hazhzeng approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrdmr @Hazhzeng