Skip to content

Update the max TP threads count to sys.maxsize #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Jul 20, 2021

Description

With new work being done on the Host side control concurrency, the 32 thread number isn't required. Setting the max value to MAXINT.

Fixes #873


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@vrdmr vrdmr changed the title Update the max TP threads count to 1024 Update the max TP threads count to sys.maxsize Jul 22, 2021
Copy link

@AnatoliB AnatoliB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would even recommend removing the code performing this check, including the unit tests and comments, as this is effectively dead code now. But I'll leave this up to you. Other than that, LGTM and thank you!

@vrdmr
Copy link
Member Author

vrdmr commented Jul 23, 2021

@AnatoliB - Yes, that's the plan - to remove the code and the unit tests. I wanted to get this change in sooner to unblock the perf testing work and get this part of the next week's release.

@vrdmr vrdmr merged commit e9afecc into dev Jul 23, 2021
@vrdmr vrdmr deleted the vameru/update-ptptc-count branch July 23, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying PYTHON_THREADPOOL_THREAD_COUNT larger than 32
3 participants