[PS][Monitor] Add breaking change for ScheduledQueryRule #28227
+121
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds breaking change annotations for the ScheduledQueryRule module, indicating that certain parameter and output property types will change from arrays to lists in a future release. The changes include reorganizing the module structure by moving it from a generated location to the src directory and adding comprehensive breaking change warnings.
- Added breaking change attributes to parameters (Value, Dimension) and output properties (ActionGroup, CriterionAllOf, Scope, TargetResourceType)
- Moved ScheduledQueryRule module from generated directory to src directory structure
- Updated changelog to document the breaking changes for affected cmdlets
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Monitor/ScheduledQueryRule.Autorest/resources/README.md | Added new documentation file explaining the resources directory structure |
| src/Monitor/ScheduledQueryRule.Autorest/generate-info.json | Updated generation ID for the module |
| src/Monitor/ScheduledQueryRule.Autorest/docs/Az.ScheduledQueryRule.md | Updated module GUID in documentation |
| src/Monitor/ScheduledQueryRule.Autorest/custom/New-AzScheduledQueryRuleDimensionObject.ps1 | Added breaking change attribute for Value parameter |
| src/Monitor/ScheduledQueryRule.Autorest/custom/New-AzScheduledQueryRuleConditionObject.ps1 | Added breaking change attribute for Dimension parameter |
| src/Monitor/ScheduledQueryRule.Autorest/README.md | Added breaking change directives for parameters and output properties |
| src/Monitor/ScheduledQueryRule.Autorest/Properties/AssemblyInfo.cs | Added new assembly information file |
| src/Monitor/Monitor/ChangeLog.md | Updated changelog with breaking change information for ScheduledQueryRule cmdlets |
| src/Monitor/Monitor/Az.Monitor.psd1 | Updated generation date |
| src/Monitor/Monitor.sln | Reorganized project references for ScheduledQueryRule module |
src/Monitor/ScheduledQueryRule.Autorest/custom/New-AzScheduledQueryRuleDimensionObject.ps1
Show resolved
Hide resolved
src/Monitor/ScheduledQueryRule.Autorest/custom/New-AzScheduledQueryRuleConditionObject.ps1
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
JoyerJin
added
the
Breaking Change Preannounce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.