Fix spanprobe ratelimit and add more logs

Author: dudikeleti

tracer/src/Datadog.Trace/Debugger/Expressions/ProbeExpressionsProcessor.cs

@@ -10,6 +10,7 @@
 using Datadog.Trace.Debugger.Snapshots;
 using Datadog.Trace.Logging;
 using Datadog.Trace.Vendors.Newtonsoft.Json;
+using Datadog.Trace.Vendors.Serilog.Events;
 
 namespace Datadog.Trace.Debugger.Expressions
 {
@@ -54,6 +55,11 @@ internal void AddProbeProcessor(ProbeDefinition probe)
             catch (Exception e)
             {
                 Log.Error(e, "Failed to create probe processor for probe: {Id}", probe.Id);
+            }
+
+            if (Log.IsEnabled(LogEventLevel.Debug))
+            {
+                Log.Debug("Successfully created probe processor for probe: {Id}", probe.Id);
                 Log.Debug("Probe definition is {Probe}", JsonConvert.SerializeObject(probe));
             }
         }

tracer/src/Datadog.Trace/Debugger/LiveDebugger.cs

@@ -239,6 +239,7 @@ internal void UpdateAddedProbeInstrumentations(IReadOnlyList<ProbeDefinition> ad
                                     fetchProbeStatus.Add(new FetchProbeStatus(probe.Id, probe.Version ?? 0, new ProbeStatus(probe.Id, Sink.Models.Status.RECEIVED, errorMessage: null)));
                                     break;
                                 case LiveProbeResolveStatus.Error:
+                                    Log.Warning("ProbeID {ProbeID} error resolving live. Error: {Error}", probe.Id, message);
                                     fetchProbeStatus.Add(new FetchProbeStatus(probe.Id, probe.Version ?? 0, new ProbeStatus(probe.Id, Sink.Models.Status.ERROR, errorMessage: message)));
                                     break;
                             }
@@ -295,7 +296,7 @@ private static void SetRateLimit(ProbeDefinition probe)
                 case LogProbe logProbe:
                     ProbeRateLimiter.Instance.SetRate(probe.Id, logProbe.CaptureSnapshot ? 1 : 5000);
                     break;
-                case SpanDecorationProbe or MetricProbe:
+                case SpanDecorationProbe or MetricProbe or SpanProbe:
                     ProbeRateLimiter.Instance.TryAddSampler(probe.Id, NopAdaptiveSampler.Instance);
                     break;
             }