Proper fix to prevent double fetching from background (#2279)

Author: rnystrom

Classes/Notifications/NotificationModelController.swift

@@ -51,13 +51,6 @@ final class NotificationModelController {
         width: CGFloat,
         completion: @escaping (Result<([NotificationViewModel], Int?)>) -> Void
         ) {
-        // hack to prevent double-fetching notifications when awaking from bg fetch
-        guard UIApplication.shared.applicationState != .background else {
-            // return success to avoid error states
-            completion(.success(([], nil)))
-            return
-        }
-
         let badge = githubClient.badge
         let contentSizeCategory = UIContentSizeCategory.preferred
         // TODO move handling + parsing to a single method?

Classes/Systems/Feed.swift

@@ -76,7 +76,10 @@ final class Feed: NSObject, UIScrollViewDelegate {
 
         view.backgroundColor = .white
 
-        refresh()
+        // avoid app launch in the background triggering viewDidLoad-based network calls
+        if UIApplication.shared.applicationState != .background {
+            refresh()
+        }
 
         adapter.collectionView = collectionView