always call completion block when early returning b/c of bg (#2258)

Author: rnystrom

Classes/Notifications/NotificationModelController.swift

@@ -52,7 +52,11 @@ final class NotificationModelController {
         completion: @escaping (Result<([NotificationViewModel], Int?)>) -> Void
         ) {
         // hack to prevent double-fetching notifications when awaking from bg fetch
-        guard UIApplication.shared.applicationState != .background else { return }
+        guard UIApplication.shared.applicationState != .background else {
+            // return success to avoid error states
+            completion(.success(([], nil)))
+            return
+        }
 
         let badge = githubClient.badge
         let contentSizeCategory = UIContentSizeCategory.preferred

Classes/View Controllers/SplitViewControllerDelegate.swift

@@ -31,11 +31,16 @@ final class SplitViewControllerDelegate: UISplitViewControllerDelegate {
             let primaryNav = tab.selectedViewController as? UINavigationController,
             let secondaryNav = secondaryViewController as? UINavigationController {
 
-            // remove any placeholder VCs from the stack
-            primaryNav.viewControllers += secondaryNav.viewControllers.filter {
+            let collapsedControllers = secondaryNav.viewControllers.filter {
                 $0.hidesBottomBarWhenPushed = true
+                // remove any placeholder VCs from the stack
                 return ($0 is SplitPlaceholderViewController) == false
             }
+            // avoid setting view controllers b/c can result in viewDidLoad being called
+            // https://github.com/GitHawkApp/GitHawk/issues/2230
+            if collapsedControllers.count > 0 {
+                primaryNav.viewControllers += collapsedControllers
+            }
         }
 
         return true