Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Enable localised Inbox Zero dates #2164

@Sherlouk

Description

@Sherlouk

Is your feature request related to a problem? Please describe.
Currently the "Inbox Zero" message can be changed depending on the current date and if there's a holiday such as Christmas or New Years but these dates are mostly for America and there are some differences around the world.

As GitHub is world-wide it would be nice if we had a way to change the holidays and the dates they land on depending on the origin of the user. For example: Mother's Day is 31st March 2019 in the UK and 12th May 2019 in the US!

Describe the solution you'd like
As per Ryan's suggestion in the PR we could add the user's locale to the holiday's endpoint like below:
http://githawk.com/holidays-UK.json

This would return different holidays or the same ones on different days.

We would likely want to handle the case where we don't support a particular locale, maybe falling back to a default one without a locale?

Describe alternatives you've considered
Alternatives could be using one file as it currently does but providing an array of locale codes that it is enabled for.

On the same line of suggestion, we could provide a dictionary of locale code to dates if they differ.

Open to suggestions!

Additional context
Some comments in the pull request which introduced the functionality
#2142

Metadata

Metadata

Assignees

No one assigned

    Labels

    low priorityLow priority issue/feature🆕 feature requestA feature being requested to be added, not yet approved

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions