diff --git a/Classes/Image Upload/ImageUploadTableViewController.swift b/Classes/Image Upload/ImageUploadTableViewController.swift index 0517c21b7..dddbc89bb 100755 --- a/Classes/Image Upload/ImageUploadTableViewController.swift +++ b/Classes/Image Upload/ImageUploadTableViewController.swift @@ -189,8 +189,8 @@ class ImageUploadTableViewController: UITableViewController { description: "") { [weak self] result in switch result { - case .error: - Squawk.showGenericError() + case .error(let error): + Squawk.show(error: error) self?.setRightBarItemIdle() case .success(let link): diff --git a/Classes/Issues/AddCommentClient.swift b/Classes/Issues/AddCommentClient.swift index 6a60fdee0..4df82244d 100644 --- a/Classes/Issues/AddCommentClient.swift +++ b/Classes/Issues/AddCommentClient.swift @@ -61,11 +61,11 @@ final class AddCommentClient { viewerCanDelete: fragments.deletableFields.viewerCanDelete ) } - case .failure: + case .failure(let error): for listener in self.listeners { listener.listener?.didFailSendingComment(client: self, subjectId: subjectId, body: body) } - Squawk.showGenericError() + Squawk.show(error: error) } } } diff --git a/Classes/Issues/Comments/IssueCommentSectionController.swift b/Classes/Issues/Comments/IssueCommentSectionController.swift index e37d673d5..fe2751040 100644 --- a/Classes/Issues/Comments/IssueCommentSectionController.swift +++ b/Classes/Issues/Comments/IssueCommentSectionController.swift @@ -261,11 +261,10 @@ final class IssueCommentSectionController: commentID: "\(number)") ) { [weak self] result in switch result { - case .failure: + case .failure(let error): self?.hasBeenDeleted = false self?.update(animated: trueUnlessReduceMotionEnabled) - - Squawk.showGenericError() + Squawk.show(error: error) case .success: break // Don't need to handle success since updated optimistically } } @@ -297,9 +296,9 @@ final class IssueCommentSectionController: ) { [weak self] result in switch result { case .success: break - case .failure: + case .failure(let error): self?.edit(markdown: originalMarkdown) - Squawk.showGenericError() + Squawk.show(error: error) } } } diff --git a/Classes/Issues/EditComment/EditCommentViewController.swift b/Classes/Issues/EditComment/EditCommentViewController.swift index 1a00efec3..1f5ff0d4f 100644 --- a/Classes/Issues/EditComment/EditCommentViewController.swift +++ b/Classes/Issues/EditComment/EditCommentViewController.swift @@ -173,7 +173,9 @@ MessageTextViewListener { ) { [weak self] result in switch result { case .success: self?.didSave(markdown: markdown) - case .failure: self?.error() + case .failure(let error): + self?.setRightBarItemIdle() + Squawk.show(error: error) } } } @@ -183,11 +185,6 @@ MessageTextViewListener { delegate?.didEditComment(viewController: self, markdown: markdown) } - func error() { - setRightBarItemIdle() - Squawk.showGenericError() - } - // MARK: MessageTextViewListener func didChange(textView: MessageTextView) { diff --git a/Classes/Issues/GithubClient+Issues.swift b/Classes/Issues/GithubClient+Issues.swift index bf5e8b080..3c6b67a69 100644 --- a/Classes/Issues/GithubClient+Issues.swift +++ b/Classes/Issues/GithubClient+Issues.swift @@ -59,9 +59,9 @@ extension GithubClient { client.query(query, result: { $0.repository }) { result in switch result { - case .failure: - completion(.error(nil)) - Squawk.showGenericError() + case .failure(let error): + completion(.error(error)) + Squawk.show(error: error) case .success(let repository): let issueOrPullRequest = repository.issueOrPullRequest guard let issueType: IssueType = issueOrPullRequest?.asIssue ?? issueOrPullRequest?.asPullRequest else { @@ -193,13 +193,9 @@ extension GithubClient { switch result { case .success(let data): completion(createIssueReactions(reactions: data)) - case .failure(let err): + case .failure(let error): completion(nil) - if let message = err?.localizedDescription { - Squawk.showError(message: message) - } else { - Squawk.showGenericError() - } + Squawk.show(error: error) } } @@ -252,9 +248,9 @@ extension GithubClient { client.send(V3SetIssueStatusRequest(owner: owner, repo: repo, number: number, state: stateString)) { result in switch result { case .success: break - case .failure: + case .failure(let error): cache.set(value: previous) - Squawk.showGenericError() + Squawk.show(error: error) } } } @@ -294,10 +290,10 @@ extension GithubClient { switch result { case .success: completion?(.success(true)) - case .failure: + case .failure(let error): cache.set(value: previous) - Squawk.showGenericError() - completion?(.error(nil)) + Squawk.show(error: error) + completion?(.error(error)) } } } @@ -405,9 +401,9 @@ extension GithubClient { ) { result in switch result { case .success: break - case .failure: + case .failure(let error): cache.set(value: previous) - Squawk.showGenericError() + Squawk.show(error: error) } } } @@ -503,9 +499,9 @@ extension GithubClient { ) { result in switch result { case .success: break - case .failure: + case .failure(let error): cache.set(value: previous) - Squawk.showGenericError() + Squawk.show(error: error) } } } @@ -523,9 +519,9 @@ extension GithubClient { ) { result in switch result { case .success: break - case .failure: + case .failure(let error): cache.set(value: previous) - Squawk.showGenericError() + Squawk.show(error: error) } } } diff --git a/Classes/Issues/IssuesViewController.swift b/Classes/Issues/IssuesViewController.swift index 7210f3b2c..b7b7a0013 100644 --- a/Classes/Issues/IssuesViewController.swift +++ b/Classes/Issues/IssuesViewController.swift @@ -304,8 +304,8 @@ final class IssuesViewController: } // avoid finishLoading() so empty view doesn't appear self?.feed.adapter.performUpdates(animated: trueUnlessReduceMotionEnabled) - case .error: - Squawk.showGenericError() + case .error(let error): + Squawk.show(error: error) } } } diff --git a/Classes/Issues/Merge/GithubClient+Merge.swift b/Classes/Issues/Merge/GithubClient+Merge.swift index 459ddcb9a..b57ee6f3b 100644 --- a/Classes/Issues/Merge/GithubClient+Merge.swift +++ b/Classes/Issues/Merge/GithubClient+Merge.swift @@ -54,8 +54,8 @@ extension GithubClient { switch result { case .success: cache.set(value: optimisticResult) - case .failure: - Squawk.showGenericError() + case .failure(let err): + Squawk.show(error: err) error() } } diff --git a/Classes/Labels/LabelsViewController.swift b/Classes/Labels/LabelsViewController.swift index 74eebc8af..d3521b1f4 100644 --- a/Classes/Labels/LabelsViewController.swift +++ b/Classes/Labels/LabelsViewController.swift @@ -68,8 +68,8 @@ final class LabelsViewController: BaseListViewController2, BaseListViewC return RepositoryLabel(color: node.color, name: node.name) }.sorted { $0.name < $1.name } self?.update(animated: true) - case .failure: - Squawk.showGenericError() + case .failure(let error): + Squawk.show(error: error) } } } diff --git a/Classes/Milestones/GithubClient+Milestones.swift b/Classes/Milestones/GithubClient+Milestones.swift index a57871763..690a9189e 100644 --- a/Classes/Milestones/GithubClient+Milestones.swift +++ b/Classes/Milestones/GithubClient+Milestones.swift @@ -97,9 +97,9 @@ extension GithubClient { ) { result in switch result { case .success: break - case .failure: + case .failure(let error): cache.set(value: previous) - Squawk.showGenericError() + Squawk.show(error: error) } } } diff --git a/Classes/Milestones/MilestonesViewController.swift b/Classes/Milestones/MilestonesViewController.swift index 6f463e3f1..f50ca26a4 100644 --- a/Classes/Milestones/MilestonesViewController.swift +++ b/Classes/Milestones/MilestonesViewController.swift @@ -64,8 +64,8 @@ MilestoneSectionControllerDelegate { switch result { case .success(let milestones): self?.milestones = milestones - case .error: - Squawk.showGenericError() + case .error(let error): + Squawk.show(error: error) } self?.update(animated: true) } diff --git a/Classes/New Issue/NewIssueTableViewController.swift b/Classes/New Issue/NewIssueTableViewController.swift index 1c7820ee7..d6c4f5944 100644 --- a/Classes/New Issue/NewIssueTableViewController.swift +++ b/Classes/New Issue/NewIssueTableViewController.swift @@ -167,8 +167,8 @@ final class NewIssueTableViewController: UITableViewController, UITextFieldDeleg strongSelf.dismiss(animated: trueUnlessReduceMotionEnabled, completion: { delegate?.didDismissAfterCreatingIssue(model: model) }) - case .failure: - Squawk.showGenericError() + case .failure(let error): + Squawk.show(error: error) } } } diff --git a/Classes/Notifications/NotificationSectionController.swift b/Classes/Notifications/NotificationSectionController.swift index 620bd4900..04d389787 100644 --- a/Classes/Notifications/NotificationSectionController.swift +++ b/Classes/Notifications/NotificationSectionController.swift @@ -109,8 +109,8 @@ final class NotificationSectionController: ListSwiftSectionController 0 { - Squawk.showGenericError() + } else if let graphQL = graphQLErrors?.first { + Squawk.show(error: graphQL) } }