From 397cf8a3dbce381264401636b5d571a15c073e9f Mon Sep 17 00:00:00 2001 From: Ryan Nystrom Date: Sat, 27 Oct 2018 15:59:28 -0400 Subject: [PATCH 1/3] fix lints --- Classes/History/PathCommitSectionController.swift | 1 - Classes/Issues/IssuesViewController.swift | 7 ++++--- Classes/Issues/Labeled/IssueLabeledSectionController.swift | 5 +++-- Classes/Issues/Labels/IssueLabelsSectionController.swift | 4 ++-- Classes/Repository/RepositoryIssuesViewController.swift | 5 +++-- Classes/Systems/AppRouter/RepoRoute+RoutePerformable.swift | 1 + .../View Controllers/UIViewController+PresentLabels.swift | 3 ++- 7 files changed, 15 insertions(+), 11 deletions(-) diff --git a/Classes/History/PathCommitSectionController.swift b/Classes/History/PathCommitSectionController.swift index c2434a96f..dcbfe2d18 100644 --- a/Classes/History/PathCommitSectionController.swift +++ b/Classes/History/PathCommitSectionController.swift @@ -34,4 +34,3 @@ final class PathCommitSectionController: ListSwiftSectionController, -ListBindingSectionControllerDataSource, + ListBindingSectionControllerDataSource, ListBindingSectionControllerSelectionDelegate { private let issue: IssueDetailsModel @@ -108,3 +107,4 @@ ListBindingSectionControllerSelectionDelegate { } } + diff --git a/Classes/Repository/RepositoryIssuesViewController.swift b/Classes/Repository/RepositoryIssuesViewController.swift index bfe6fa659..b709f78bb 100644 --- a/Classes/Repository/RepositoryIssuesViewController.swift +++ b/Classes/Repository/RepositoryIssuesViewController.swift @@ -15,7 +15,7 @@ enum RepositoryIssuesType { } class RepositoryIssuesViewController: BaseListViewController, -BaseListViewControllerDataSource, + BaseListViewControllerDataSource, SearchBarSectionControllerDelegate { private var models = [ListDiffable]() @@ -58,7 +58,7 @@ SearchBarSectionControllerDelegate { super.viewDidLoad() makeBackBarItemEmpty() - + let presentingInTabMan = label == nil if presentingInTabMan { // set the frame in -viewDidLoad is required when working with TabMan @@ -143,3 +143,4 @@ SearchBarSectionControllerDelegate { } } + diff --git a/Classes/Systems/AppRouter/RepoRoute+RoutePerformable.swift b/Classes/Systems/AppRouter/RepoRoute+RoutePerformable.swift index c48c73ae7..bb0e246fd 100644 --- a/Classes/Systems/AppRouter/RepoRoute+RoutePerformable.swift +++ b/Classes/Systems/AppRouter/RepoRoute+RoutePerformable.swift @@ -28,3 +28,4 @@ extension RepoRoute: RoutePerformable { return true } } + diff --git a/Classes/View Controllers/UIViewController+PresentLabels.swift b/Classes/View Controllers/UIViewController+PresentLabels.swift index 434130778..7bb9cceb9 100644 --- a/Classes/View Controllers/UIViewController+PresentLabels.swift +++ b/Classes/View Controllers/UIViewController+PresentLabels.swift @@ -19,10 +19,11 @@ extension UIViewController { type: type, label: label ) - + navigationController?.pushViewController( repositoryIssuesViewController, animated: true ) } } + From e35d9e7c233c1f1ca456ecd87ca05704bc3158b1 Mon Sep 17 00:00:00 2001 From: Ryan Nystrom Date: Sat, 27 Oct 2018 16:00:34 -0400 Subject: [PATCH 2/3] lowercase search string --- Classes/Repository/RepositoryIssuesViewController.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/Repository/RepositoryIssuesViewController.swift b/Classes/Repository/RepositoryIssuesViewController.swift index b709f78bb..b1886e1ad 100644 --- a/Classes/Repository/RepositoryIssuesViewController.swift +++ b/Classes/Repository/RepositoryIssuesViewController.swift @@ -139,7 +139,7 @@ SearchBarSectionControllerDelegate { case .issues: typeQuery = "is:issue" case .pullRequests: typeQuery = "is:pr" } - return "repo:\(owner)/\(repo) \(typeQuery) \(previousSearchString)" + return "repo:\(owner)/\(repo) \(typeQuery) \(previousSearchString)".lowercased() } } From c4c48aaf857dfb2b3c18ee2087e9240a6d090d29 Mon Sep 17 00:00:00 2001 From: Ryan Nystrom Date: Sat, 27 Oct 2018 16:01:55 -0400 Subject: [PATCH 3/3] fix more lints --- Classes/Issues/IssuesViewController.swift | 4 +--- Classes/Issues/Labeled/IssueLabeledSectionController.swift | 3 --- Classes/Issues/Labels/IssueLabelsSectionController.swift | 1 - Classes/Repository/RepositoryIssuesViewController.swift | 1 - Classes/Systems/AppRouter/RepoRoute+RoutePerformable.swift | 1 - Classes/View Controllers/UIViewController+PresentLabels.swift | 1 - 6 files changed, 1 insertion(+), 10 deletions(-) diff --git a/Classes/Issues/IssuesViewController.swift b/Classes/Issues/IssuesViewController.swift index 2bd117217..8a3f0ec3e 100644 --- a/Classes/Issues/IssuesViewController.swift +++ b/Classes/Issues/IssuesViewController.swift @@ -35,8 +35,7 @@ final class IssuesViewController: MessageViewController, IssueTextActionsViewSendDelegate, EmptyViewDelegate, MessageTextViewListener, - IssueLabelTapSectionControllerDelegate -{ + IssueLabelTapSectionControllerDelegate { private let client: GithubClient private let model: IssueDetailsModel @@ -644,4 +643,3 @@ final class IssuesViewController: MessageViewController, } } - diff --git a/Classes/Issues/Labeled/IssueLabeledSectionController.swift b/Classes/Issues/Labeled/IssueLabeledSectionController.swift index 578048b6d..61087c86a 100644 --- a/Classes/Issues/Labeled/IssueLabeledSectionController.swift +++ b/Classes/Issues/Labeled/IssueLabeledSectionController.swift @@ -9,8 +9,6 @@ import Foundation import IGListKit - - final class IssueLabeledSectionController: ListGenericSectionController, MarkdownStyledTextViewDelegate { private let issueModel: IssueDetailsModel @@ -45,4 +43,3 @@ final class IssueLabeledSectionController: ListGenericSectionController