Skip to content

Commit 05a5abd

Browse files
Merge pull request #752 from IntelPython/restore-cython-coverage
CYTHON_TRACE must be set when generating coverage
2 parents 148e47e + 6fab702 commit 05a5abd

File tree

3 files changed

+23
-3
lines changed

3 files changed

+23
-3
lines changed

dpctl/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
*.so
22
*.cpp
3+
*.cxx
34
*.c
45
*.h
56
memory/*.h

dpctl/CMakeLists.txt

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11

22
find_package(PythonExtensions REQUIRED)
33
find_package(NumPy REQUIRED)
4+
5+
set(CYTHON_FLAGS "-w ${CMAKE_SOURCE_DIR}")
46
find_package(Cython REQUIRED)
57

68
if(WIN32)
@@ -111,6 +113,10 @@ function(build_dpctl_ext _trgt _src _dest)
111113
add_library(${_trgt} MODULE ${_generated_src})
112114
target_include_directories(${_trgt} PRIVATE ${NumPy_INCLUDE_DIR} ${DPCTL_INCLUDE_DIR})
113115
add_dependencies(${_trgt} _build_time_create_dpctl_include)
116+
if (DPCTL_GENERATE_COVERAGE)
117+
target_compile_definitions(${_trgt} PRIVATE CYTHON_TRACE=1 CYTHON_TRACE_NOGIL=1)
118+
target_compile_options(${_trgt} PRIVATE -fno-sycl-use-footer)
119+
endif()
114120
target_link_libraries(${_trgt} DPCTLSyclInterface)
115121
target_link_options(${_trgt} PRIVATE "LINKER:${DPCTL_LDFLAGS}")
116122
python_extension_module(${_trgt})
@@ -124,15 +130,28 @@ function(build_dpctl_ext _trgt _src _dest)
124130
COMMAND ${CMAKE_COMMAND}
125131
-DSOURCE_FILE=${_generated_public_h}
126132
-DDEST=${CMAKE_CURRENT_SOURCE_DIR}
127-
-P ${CMAKE_SOURCE_DIR}/dpctl/cmake/copy_generated_headers.cmake
133+
-P ${CMAKE_SOURCE_DIR}/dpctl/cmake/copy_existing.cmake
128134
COMMAND ${CMAKE_COMMAND}
129135
-DSOURCE_FILE=${_generated_api_h}
130136
-DDEST=${CMAKE_CURRENT_SOURCE_DIR}
131-
-P ${CMAKE_SOURCE_DIR}/dpctl/cmake/copy_generated_headers.cmake
137+
-P ${CMAKE_SOURCE_DIR}/dpctl/cmake/copy_existing.cmake
132138
DEPENDS ${_trgt}
133139
VERBATIM
134-
COMMENT "Copying Cython-generated headers to destination"
140+
COMMENT "Copying Cython-generated headers to dpctl"
135141
)
142+
if (DPCTL_GENERATE_COVERAGE)
143+
set(_copy_cxx_trgt "${_trgt}_copy_cxx")
144+
add_custom_target(
145+
${_copy_cxx_trgt} ALL
146+
COMMAND ${CMAKE_COMMAND}
147+
-DSOURCE_FILE=${_generated_src}
148+
-DDEST=${CMAKE_CURRENT_SOURCE_DIR}
149+
-P ${CMAKE_SOURCE_DIR}/dpctl/cmake/copy_existing.cmake
150+
DEPENDS ${_trgt}
151+
VERBATIM
152+
COMMENT "Copying Cython-generated source to dpctl"
153+
)
154+
endif()
136155
install(TARGETS ${_trgt} LIBRARY DESTINATION ${_dest})
137156
endfunction()
138157

0 commit comments

Comments
 (0)