Skip to content

Commit 634d01e

Browse files
Fix comments and flake8
1 parent af1e72e commit 634d01e

File tree

2 files changed

+26
-21
lines changed

2 files changed

+26
-21
lines changed

dpctl/_sycl_event.pyx

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ import logging
2525

2626
from cpython cimport pycapsule
2727

28-
from ._backend cimport (
28+
from ._backend cimport ( # noqa: E211
2929
DPCTLEvent_Create,
3030
DPCTLEvent_Delete,
3131
DPCTLEvent_Wait,
32-
DPCTLSyclEventRef,
32+
DPCTLSyclEventRef,
3333
DPCTLEvent_Copy
3434
)
3535

@@ -84,15 +84,15 @@ cdef void _event_capsule_deleter(object o):
8484

8585

8686
cdef class _SyclEventRaw:
87-
""" Python wrapper class for a cl::sycl::event.
87+
""" Python wrapper class for a ``cl::sycl::event``.
8888
"""
8989

9090
def __dealloc__(self):
9191
DPCTLEvent_Delete(self._event_ref)
9292

9393

9494
cdef class SyclEventRaw(_SyclEventRaw):
95-
""" Python wrapper class for a cl::sycl::event.
95+
""" Python wrapper class for a ``cl::sycl::event``.
9696
"""
9797

9898
@staticmethod
@@ -122,7 +122,7 @@ cdef class SyclEventRaw(_SyclEventRaw):
122122
if (self._event_ref is NULL):
123123
return -1
124124
return 0
125-
125+
126126
cdef int _init_event_from_capsule(self, object cap):
127127
cdef DPCTLSyclEventRef ERef = NULL
128128
cdef DPCTLSyclEventRef ERef_copy = NULL
@@ -144,9 +144,9 @@ cdef class SyclEventRaw(_SyclEventRaw):
144144
else:
145145
return -128
146146

147-
def __cinit__(self,arg=None):
147+
def __cinit__(self, arg=None):
148148
cdef int ret = 0
149-
if arg == None:
149+
if arg is None:
150150
ret = self._init_event_default()
151151
elif isinstance(arg, _SyclEventRaw):
152152
ret = self._init_event_from__SyclEventRaw(<_SyclEventRaw> arg)
@@ -175,22 +175,22 @@ cdef class SyclEventRaw(_SyclEventRaw):
175175
)
176176

177177
cdef DPCTLSyclEventRef get_event_ref(self):
178-
""" Returns the DPCTLSyclEventRef pointer for this class.
178+
""" Returns the `DPCTLSyclEventRef` pointer for this class.
179179
"""
180180
return self._event_ref
181181

182182
cpdef void wait(self):
183183
DPCTLEvent_Wait(self._event_ref)
184184

185185
def addressof_ref(self):
186-
""" Returns the address of the C API DPCTLSyclEventRef pointer as
186+
""" Returns the address of the C API `DPCTLSyclEventRef` pointer as
187187
a size_t.
188188
189189
Returns:
190-
The address of the DPCTLSyclEventRef object used to create this
191-
SyclEvent cast to a size_t.
190+
The address of the `DPCTLSyclEventRef` object used to create this
191+
`SyclEvent` cast to a size_t.
192192
"""
193-
return int(<size_t>self._event_ref)
193+
return <size_t>self._event_ref
194194

195195
def _get_capsule(self):
196196
cdef DPCTLSyclEventRef ERef = NULL

dpctl/tests/test_sycl_event.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,28 +18,25 @@
1818
"""
1919

2020
import pytest
21-
import ctypes
2221
import numpy as np
2322

2423
import dpctl
2524
import dpctl.memory as dpctl_mem
2625
import dpctl.program as dpctl_prog
2726

28-
from ._helper import has_gpu
29-
3027

3128
def test_create_default_event_raw():
3229
try:
33-
event = dpctl.SyclEventRaw()
30+
dpctl.SyclEventRaw()
3431
except ValueError:
3532
pytest.fail("Failed to create a default event")
3633

3734

3835
def test_create_event_raw_from_SyclEvent():
3936
oclSrc = " \
40-
kernel void add(global int* a) { \
41-
size_t index = get_global_id(0); \
42-
a[index] = a[index] + 1; \
37+
kernel void add(global int* a) { \
38+
size_t index = get_global_id(0); \
39+
a[index] = a[index] + 1; \
4340
}"
4441
q = dpctl.SyclQueue("opencl:gpu")
4542
prog = dpctl_prog.create_program_from_source(q, oclSrc)
@@ -56,7 +53,7 @@ def test_create_event_raw_from_SyclEvent():
5653
ev = q.submit(addKernel, args, r)
5754

5855
try:
59-
ev_copy = dpctl.SyclEventRaw(ev)
56+
dpctl.SyclEventRaw(ev)
6057
except ValueError:
6158
pytest.fail("Failed to create an event from SyclEvent")
6259

@@ -65,6 +62,14 @@ def test_create_event_raw_from_capsule():
6562
try:
6663
event = dpctl.SyclEventRaw()
6764
event_capsule = event._get_capsule()
68-
event_from_cap = dpctl.SyclEventRaw(event_capsule)
65+
dpctl.SyclEventRaw(event_capsule)
6966
except ValueError:
7067
pytest.fail("Failed to create an event from capsule")
68+
69+
70+
def test_copy_event():
71+
ev = dpctl.SyclEventRaw()
72+
try:
73+
dpctl.SyclEventRaw(ev)
74+
except ValueError:
75+
pytest.fail("Failed to copy SyclEventRaw event")

0 commit comments

Comments
 (0)