Add tests to check validation of __sycl_usm_array_interface__ in memory objects

Author: oleksandr-pavlyk

dpctl/tests/test_sycl_usm.py

@@ -278,12 +278,15 @@ def test_sycl_usm_array_interface(memory_ctor):
 
 
 class View:
-    def __init__(self, buf, shape, strides, offset, syclobj=None):
+    def __init__(
+        self, buf, shape, strides, offset, syclobj=None, transf_fn=None
+    ):
         self.buffer_ = buf
         self.shape_ = shape
         self.strides_ = strides
         self.offset_ = offset
         self.syclobj_ = syclobj
+        self.transf_fn_ = transf_fn
 
     @property
     def __sycl_usm_array_interface__(self):
@@ -293,6 +296,8 @@ def __sycl_usm_array_interface__(self):
         sua_iface["strides"] = self.strides_
         if self.syclobj_:
             sua_iface["syclobj"] = self.syclobj_
+        if self.transf_fn_:
+            sua_iface = self.transf_fn_(sua_iface)
         return sua_iface
 
 
@@ -360,6 +365,95 @@ def test_suai_non_contig_2D(memory_ctor):
     assert np.array_equal(res, expected_res)
 
 
+def test_suai_invalid_suai():
+    n_bytes = 2 * 3 * 5 * 128
+    try:
+        q = dpctl.SyclQueue()
+    except dpctl.SyclQueueCreationError:
+        pytest.skip("Could not create default queue")
+    try:
+        buf = MemoryUSMShared(n_bytes, queue=q)
+    except Exception:
+        pytest.skip("USM-shared allocation failed")
+    # different syclobj values
+    for syclobj in [
+        q,
+        q.sycl_context,
+        q._get_capsule(),
+        q.sycl_context._get_capsule(),
+    ]:
+        v = View(buf, shape=(n_bytes,), strides=(1,), offset=0, syclobj=syclobj)
+        MemoryUSMShared(v)
+        with pytest.raises(ValueError):
+            MemoryUSMDevice(v)
+        with pytest.raises(ValueError):
+            MemoryUSMHost(v)
+
+    # version validation
+    def invalid_version(suai_iface):
+        "Set version to invalid"
+        suai_iface["version"] = 0
+        return suai_iface
+
+    v = View(
+        buf, shape=(n_bytes,), strides=(1,), offset=0, transf_fn=invalid_version
+    )
+    with pytest.raises(ValueError):
+        MemoryUSMShared(v)
+
+    # data validation
+    def invalid_data(suai_iface):
+        "Set data to invalid"
+        suai_iface["data"] = tuple()
+        return suai_iface
+
+    v = View(
+        buf, shape=(n_bytes,), strides=(1,), offset=0, transf_fn=invalid_data
+    )
+    with pytest.raises(ValueError):
+        MemoryUSMShared(v)
+    # set shape to a negative value
+    v = View(buf, shape=(-n_bytes,), strides=(2,), offset=0)
+    with pytest.raises(ValueError):
+        MemoryUSMShared(v)
+    v = View(buf, shape=(-n_bytes,), strides=None, offset=0)
+    with pytest.raises(ValueError):
+        MemoryUSMShared(v)
+    # shape validation
+    v = View(buf, shape=None, strides=(1,), offset=0)
+    with pytest.raises(ValueError):
+        MemoryUSMShared(v)
+
+    # typestr validation
+    def invalid_typestr(suai_iface):
+        suai_iface["typestr"] = "invalid"
+        return suai_iface
+
+    v = View(
+        buf, shape=(n_bytes,), strides=(1,), offset=0, transf_fn=invalid_typestr
+    )
+    with pytest.raises(ValueError):
+        MemoryUSMShared(v)
+
+    def unsupported_typestr(suai_iface):
+        suai_iface["typestr"] = "O"
+        return suai_iface
+
+    v = View(
+        buf,
+        shape=(n_bytes,),
+        strides=(1,),
+        offset=0,
+        transf_fn=unsupported_typestr,
+    )
+    with pytest.raises(ValueError):
+        MemoryUSMShared(v)
+    # set strides to invalid value
+    v = View(buf, shape=(n_bytes,), strides=Ellipsis, offset=0)
+    with pytest.raises(ValueError):
+        MemoryUSMShared(v)
+
+
 def check_view(v):
     """
     Memory object created from duck __sycl_usm_array_interface__ argument