Skip to content

Commit 9f8c708

Browse files
oleksandr-pavlykndgrigorian
authored andcommitted
Adrressed PR review feedback
1 parent 4db6d20 commit 9f8c708

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

dpctl/_sycl_device.pyx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1132,7 +1132,8 @@ cdef class SyclDevice(_SyclDevice):
11321132
int: Cache size in bytes
11331133
"""
11341134
cdef uint64_t cache_sz = DPCTLDevice_GetGlobalMemCacheSize(
1135-
self._device_ref)
1135+
self._device_ref
1136+
)
11361137
return cache_sz
11371138

11381139
@property
@@ -1143,7 +1144,8 @@ cdef class SyclDevice(_SyclDevice):
11431144
int: Cache size in bytes
11441145
"""
11451146
cdef uint64_t cache_line_sz = DPCTLDevice_GetGlobalMemCacheLineSize(
1146-
self._device_ref)
1147+
self._device_ref
1148+
)
11471149
return cache_line_sz
11481150

11491151
cdef cpp_bool equals(self, SyclDevice other):

dpctl/program/_program.pyx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,8 @@ cdef class SyclKernel:
122122
a multiple, for executing the kernel on the device it was built for.
123123
"""
124124
cdef size_t v = DPCTLKernel_GetPreferredWorkGroupSizeMultiple(
125-
self._kernel_ref)
125+
self._kernel_ref
126+
)
126127
return v
127128

128129
@property

libsyclinterface/include/dpctl_sycl_kernel_interface.h

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ DPCTL_C_EXTERN_C_BEGIN
4242
* @brief Returns the number of arguments for the sycl
4343
* interoperability kernel.
4444
*
45-
* @param KRef DPCTLSyclKernelRef pointer to an SYCL
45+
* @param KRef DPCTLSyclKernelRef pointer to a SYCL
4646
* interoperability kernel.
4747
* @return Returns the number of arguments for the interoperability
4848
* kernel.
@@ -55,7 +55,7 @@ size_t DPCTLKernel_GetNumArgs(__dpctl_keep const DPCTLSyclKernelRef KRef);
5555
* @brief Deletes the DPCTLSyclKernelRef after casting it to a
5656
* ``sycl::kernel``.
5757
*
58-
* @param KRef DPCTLSyclKernelRef pointer to an SYCL
58+
* @param KRef DPCTLSyclKernelRef pointer to a SYCL
5959
* interoperability kernel.
6060
* @ingroup KernelInterface
6161
*/
@@ -66,10 +66,11 @@ void DPCTLKernel_Delete(__dpctl_take DPCTLSyclKernelRef KRef);
6666
* !brief Wrapper around
6767
* `kernel::get_info<info::kernel_device_specific::work_group_size>()`.
6868
*
69-
* @param KRef DPCTLSyclKernelRef pointer to an SYCL
69+
* @param KRef DPCTLSyclKernelRef pointer to a SYCL
7070
* interoperability kernel.
7171
* @return Returns the maximum number of work-items in a work-group
72-
* that can be used to execute a kernel on a specific device.
72+
* that can be used to execute a kernel on the device it was
73+
* built for.
7374
* @ingroup KernelInterface
7475
*/
7576
DPCTL_API
@@ -79,10 +80,10 @@ size_t DPCTLKernel_GetWorkGroupSize(__dpctl_keep const DPCTLSyclKernelRef KRef);
7980
* !brief Wrapper around
8081
* `kernel::get_info<info::kernel_device_specific::preferred_work_group_size_multiple>()`.
8182
*
82-
* @param KRef DPCTLSyclKernelRef pointer to an SYCL
83+
* @param KRef DPCTLSyclKernelRef pointer to a SYCL
8384
* interoperability kernel.
8485
* @return Returns a value, of which work-group size is preferred to be a
85-
* multiple, for executing a kernel on a specific device.
86+
* multiple, for executing a kernel on the device it was built for.
8687
* @ingroup KernelInterface
8788
*/
8889
DPCTL_API
@@ -93,7 +94,7 @@ size_t DPCTLKernel_GetPreferredWorkGroupSizeMultiple(
9394
* !brief Wrapper around
9495
* `kernel::get_info<info::kernel_device_specific::private_mem_size>()`.
9596
*
96-
* @param KRef DPCTLSyclKernelRef pointer to an SYCL
97+
* @param KRef DPCTLSyclKernelRef pointer to a SYCL
9798
* interoperability kernel.
9899
* @return Returns the minimum amount of private memory, in bytes,
99100
* used by each work-item in the kernel.

0 commit comments

Comments
 (0)