Removed uses of cl::sycl in comments in and header files

oleksandr-pavlyk · oleksandr-pavlyk · commit d0fafce321d4 · 2022-09-04T15:39:47.000-05:00
Removed use of deprecated `sycl::info::device::profiling`
from `print_device_info` function.

Removed `DPCTLDevice_IsUnifiedHostMemory` which was DPCTL
interface to deprecated `info::device::host_unified_memory`
descriptor now that aspects are implemented.
diff --git a/dpctl/_backend.pxd b/dpctl/_backend.pxd
@@ -175,7 +175,6 @@ cdef extern from "syclinterface/dpctl_sycl_device_interface.h":
     cdef bool DPCTLDevice_IsCPU(const DPCTLSyclDeviceRef DRef)
     cdef bool DPCTLDevice_IsGPU(const DPCTLSyclDeviceRef DRef)
     cdef bool DPCTLDevice_IsHost(const DPCTLSyclDeviceRef DRef)
-    cdef bool DPCTLDevice_IsHostUnifiedMemory(const DPCTLSyclDeviceRef DRef)
     cdef bool DPCTLDevice_GetSubGroupIndependentForwardProgress(const DPCTLSyclDeviceRef DRef)
     cdef uint32_t DPCTLDevice_GetPreferredVectorWidthChar(const DPCTLSyclDeviceRef DRef)
     cdef uint32_t DPCTLDevice_GetPreferredVectorWidthShort(const DPCTLSyclDeviceRef DRef)
diff --git a/dpctl/_sycl_device.pxd b/dpctl/_sycl_device.pxd
@@ -33,7 +33,7 @@ cdef public api class _SyclDevice [
     object Py_SyclDeviceObject,
     type Py_SyclDeviceType
 ]:
-    """ A helper data-owner class to abstract a `cl::sycl::device` instance.
+    """ A helper data-owner class to abstract a `sycl::device` instance.
     """
     cdef DPCTLSyclDeviceRef _device_ref
     cdef const char *_vendor
diff --git a/dpctl/_sycl_device.pyx b/dpctl/_sycl_device.pyx
@@ -129,7 +129,7 @@ cdef class SyclSubDeviceCreationError(Exception):
 
 cdef class _SyclDevice:
     """
-    A helper data-owner class to abstract a cl::sycl::device instance.
+    A helper data-owner class to abstract a `sycl::device` instance.
     """
 
     def __dealloc__(self):
diff --git a/dpctl/_sycl_event.pxd b/dpctl/_sycl_event.pxd
@@ -36,7 +36,7 @@ cdef public api class SyclEvent(_SyclEvent) [
     object PySyclEventObject,
     type PySyclEventType
 ]:
-    """ Python wrapper class for a ``cl::sycl::event``
+    """ Python wrapper class for a ``sycl::event``
     """
     @staticmethod
     cdef SyclEvent _create (DPCTLSyclEventRef event)
diff --git a/dpctl/_sycl_event.pyx b/dpctl/_sycl_event.pyx
@@ -105,11 +105,11 @@ cdef class _SyclEvent:
 cdef class SyclEvent(_SyclEvent):
     """
     SyclEvent(arg=None)
-    Python class representing ``cl::sycl::event``. There are multiple
+    Python class representing ``sycl::event``. There are multiple
     ways to create a :class:`dpctl.SyclEvent` object:
 
         - Invoking the constructor with no arguments creates a ready event
-          using the default constructor of the ``cl::sycl::event``.
+          using the default constructor of the ``sycl::event``.
 
         :Example:
             .. code-block:: python
@@ -248,19 +248,19 @@ cdef class SyclEvent(_SyclEvent):
 
     def _get_capsule(self):
         """
-        Returns a copy of the underlying ``cl::sycl::event`` pointer as a void
+        Returns a copy of the underlying ``sycl::event`` pointer as a void
         pointer inside a named ``PyCapsule`` that has the name
         **SyclEventRef**. The ownership of the pointer inside the capsule is
         passed to the caller, and pointer is deleted when the capsule goes out
         of scope.
 
         Returns:
             :class:`pycapsule`: A capsule object storing a copy of the
-            ``cl::sycl::event`` pointer belonging to a
+            ``sycl::event`` pointer belonging to a
             :class:`dpctl.SyclEvent` instance.
         Raises:
             ValueError: If the ``DPCTLEvent_Copy`` fails to copy the
-                        ``cl::sycl::event`` pointer.
+                        ``sycl::event`` pointer.
 
         """
         cdef DPCTLSyclEventRef ERef = NULL
@@ -334,7 +334,7 @@ cdef class SyclEvent(_SyclEvent):
     def profiling_info_submit(self):
         """
         Returns the 64-bit time value in nanoseconds
-        when ``cl::sycl::command_group`` was submitted to the queue.
+        when ``sycl::command_group`` was submitted to the queue.
         """
         cdef uint64_t profiling_info_submit = 0
         profiling_info_submit = DPCTLEvent_GetProfilingInfoSubmit(
@@ -346,7 +346,7 @@ cdef class SyclEvent(_SyclEvent):
     def profiling_info_start(self):
         """
         Returns the 64-bit time value in nanoseconds
-        when ``cl::sycl::command_group`` started execution on the device.
+        when ``sycl::command_group`` started execution on the device.
         """
         cdef uint64_t profiling_info_start = 0
         profiling_info_start = DPCTLEvent_GetProfilingInfoStart(self._event_ref)
@@ -356,7 +356,7 @@ cdef class SyclEvent(_SyclEvent):
     def profiling_info_end(self):
         """
         Returns the 64-bit time value in nanoseconds
-        when ``cl::sycl::command_group`` finished execution on the device.
+        when ``sycl::command_group`` finished execution on the device.
         """
         cdef uint64_t profiling_info_end = 0
         profiling_info_end = DPCTLEvent_GetProfilingInfoEnd(self._event_ref)
diff --git a/dpctl/_sycl_platform.pxd b/dpctl/_sycl_platform.pxd
@@ -25,7 +25,7 @@ from ._backend cimport DPCTLSyclDeviceSelectorRef, DPCTLSyclPlatformRef
 
 
 cdef class _SyclPlatform:
-    ''' A helper metaclass to abstract a cl::sycl::platform instance.
+    ''' A helper metaclass to abstract a ``sycl::platform`` instance.
     '''
     cdef DPCTLSyclPlatformRef _platform_ref
     cdef const char *_vendor
diff --git a/dpctl/_sycl_platform.pyx b/dpctl/_sycl_platform.pyx
@@ -81,7 +81,7 @@ cdef void _init_helper(_SyclPlatform platform, DPCTLSyclPlatformRef PRef):
 
 cdef class SyclPlatform(_SyclPlatform):
     """ SyclPlatform(self, arg=None)
-        Python class representing ``cl::sycl::platform`` class.
+        Python class representing ``sycl::platform`` class.
 
         SyclPlatform() - create platform selected by sycl::default_selector
         SyclPlatform(filter_selector) - create platform selected by filter
diff --git a/dpctl/_sycl_queue.pyx b/dpctl/_sycl_queue.pyx
@@ -186,7 +186,7 @@ cdef class _SyclQueue:
 cdef class SyclQueue(_SyclQueue):
     """
     SyclQueue(*args, **kwargs)
-    Python class representing ``cl::sycl::queue``. There are multiple
+    Python class representing ``sycl::queue``. There are multiple
     ways to create a :class:`dpctl.SyclQueue` object:
 
         - Invoking the constructor with no arguments creates a context using
@@ -258,7 +258,7 @@ cdef class SyclQueue(_SyclQueue):
             context will be created from the specified device.
         dev (str, :class:`dpctl.SyclDevice`, capsule, optional): Sycl device
              to create :class:`dpctl.SyclQueue` from. If not specified, sycl
-             device selected by ``cl::sycl::default_selector`` is used.
+             device selected by ``sycl::default_selector`` is used.
              The argument must be explicitly specified if `ctxt` argument is
              provided.
 
diff --git a/examples/cython/sycl_direct_linkage/_buffer_example.pyx b/examples/cython/sycl_direct_linkage/_buffer_example.pyx
@@ -24,14 +24,14 @@ import numpy as np
 from cython.operator cimport dereference as deref
 
 
-cdef extern from "CL/sycl.hpp" namespace "cl::sycl":
+cdef extern from "CL/sycl.hpp" namespace "sycl":
     cdef cppclass queue nogil:
         pass
 
 
 cdef extern from "sycl_function.hpp":
     int c_columnwise_total(
-        queue& q, size_t n, size_t m, double *m, double *ct
+        queue q, size_t n, size_t m, double *m, double *ct
     ) nogil
 
 
diff --git a/examples/cython/sycl_direct_linkage/sycl_function.cpp b/examples/cython/sycl_direct_linkage/sycl_function.cpp
@@ -31,7 +31,7 @@
 #include <CL/sycl.hpp>
 #include <oneapi/mkl.hpp>
 
-int c_columnwise_total(sycl::queue &q,
+int c_columnwise_total(sycl::queue q,
                        size_t n,
                        size_t m,
                        double *mat,
diff --git a/examples/cython/sycl_direct_linkage/sycl_function.hpp b/examples/cython/sycl_direct_linkage/sycl_function.hpp
@@ -1,6 +1,6 @@
 #include <CL/sycl.hpp>
 
-int c_columnwise_total(cl::sycl::queue &,
+int c_columnwise_total(sycl::queue,
                        size_t n,
                        size_t m,
                        double *mat,
diff --git a/examples/python/device_selection.py b/examples/python/device_selection.py
@@ -22,7 +22,7 @@
 
 def create_default_device():
     """
-    Create default SyclDevice using `cl::sycl::default_selector`.
+    Create default SyclDevice using `sycl::default_selector`.
 
     Device created can be influenced by environment variable
     SYCL_DEVICE_FILTER, which determines SYCL devices seen by the
diff --git a/libsyclinterface/helper/include/dpctl_error_handlers.h b/libsyclinterface/helper/include/dpctl_error_handlers.h
@@ -42,7 +42,7 @@ class DPCTL_API DPCTL_AsyncErrorHandler
     {
     }
 
-    void operator()(const cl::sycl::exception_list &exceptions);
+    void operator()(const sycl::exception_list &exceptions);
 };
 
 enum error_level : int
diff --git a/libsyclinterface/include/dpctl_sycl_device_interface.h b/libsyclinterface/include/dpctl_sycl_device_interface.h
@@ -312,19 +312,6 @@ DPCTL_API
 __dpctl_give const char *
 DPCTLDevice_GetVendor(__dpctl_keep const DPCTLSyclDeviceRef DRef);
 
-/*!
- * @brief Returns True if the device and the host share a unified memory
- * subsystem, else returns False.
- *
- * @param    DRef           Opaque pointer to a ``sycl::device``
- * @return   Boolean indicating if the device shares a unified memory subsystem
- * with the host.
- * @ingroup DeviceInterface
- */
-DPCTL_API
-bool DPCTLDevice_IsHostUnifiedMemory(
-    __dpctl_keep const DPCTLSyclDeviceRef DRef);
-
 /*!
  * @brief Checks if two DPCTLSyclDeviceRef objects point to the same
  * sycl::device.
diff --git a/libsyclinterface/source/dpctl_sycl_device_interface.cpp b/libsyclinterface/source/dpctl_sycl_device_interface.cpp
@@ -367,20 +367,6 @@ DPCTLDevice_GetDriverVersion(__dpctl_keep const DPCTLSyclDeviceRef DRef)
     return cstr_driver;
 }
 
-bool DPCTLDevice_IsHostUnifiedMemory(__dpctl_keep const DPCTLSyclDeviceRef DRef)
-{
-    bool ret = false;
-    auto D = unwrap(DRef);
-    if (D) {
-        try {
-            ret = D->get_info<info::device::host_unified_memory>();
-        } catch (std::exception const &e) {
-            error_handler(e, __FILE__, __func__, __LINE__);
-        }
-    }
-    return ret;
-}
-
 bool DPCTLDevice_AreEq(__dpctl_keep const DPCTLSyclDeviceRef DRef1,
                        __dpctl_keep const DPCTLSyclDeviceRef DRef2)
 {
diff --git a/libsyclinterface/source/dpctl_sycl_device_manager.cpp b/libsyclinterface/source/dpctl_sycl_device_manager.cpp
@@ -58,8 +58,6 @@ std::string get_device_info_str(const device &Device)
        << Device.get_info<info::device::driver_version>() << _endl
        << std::setw(4) << " " << std::left << std::setw(16) << "Vendor"
        << Device.get_info<info::device::vendor>() << _endl << std::setw(4)
-       << " " << std::left << std::setw(16) << "Profile"
-       << Device.get_info<info::device::profile>() << _endl << std::setw(4)
        << " " << std::left << std::setw(16) << "Filter string"
        << DPCTL_GetDeviceFilterString(Device) << _endl;
 
diff --git a/libsyclinterface/tests/test_sycl_device_interface.cpp b/libsyclinterface/tests/test_sycl_device_interface.cpp
@@ -586,14 +586,6 @@ TEST_F(TestDPCTLSyclDeviceNullArgs, ChkDriverVersion)
     ASSERT_TRUE(driver_version == nullptr);
 }
 
-TEST_F(TestDPCTLSyclDeviceNullArgs, ChkIsHostUnifiedMemory)
-{
-    bool is_hum = true;
-    EXPECT_NO_FATAL_FAILURE(is_hum =
-                                DPCTLDevice_IsHostUnifiedMemory(Null_DRef));
-    ASSERT_FALSE(is_hum);
-}
-
 TEST_F(TestDPCTLSyclDeviceNullArgs, ChkAreEq)
 {
     bool are_eq = true;
