Skip to content

Replace np.empty_like(usm_ndarray_inst) with np.empty(shape, dtype=dt) #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

oleksandr-pavlyk
Copy link
Contributor

Corrected uses of np.empty_like(usm_ar) in test suite which error own due to recent change disallowing implicit data conversions.
These were subtle, albeit harmless, bugs.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Jan 15, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_448 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.683%. remained the same
when pulling 1feee2f on fix-numpy-1-26-recent-new-failures
into 6f02ec3 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 25a53f5 into master Jan 15, 2025
48 of 52 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-numpy-1-26-recent-new-failures branch January 15, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants