Cmake improvements and Coverage for C API #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2021 19:36
-- Create cmake modules to store logic to search for dpcpp, level zero,
llvm-cov, lcov.
-- Add new Cmake options to control level zero program creation and
code coverage reporting.
-- Two new rules llvm-cov and lcov-genhtml to produce code coverage
metrics.
Closed
added 7 commits
January 18, 2021 20:20
|
@PokhodenkoSA @reazulhoque @oleksandr-pavlyk Can you guys try out this PR? I will like to merge soon as my L0 work depends on the CMake changes here. |
PokhodenkoSA
approved these changes
Jan 20, 2021
| "-DCMAKE_C_COMPILER:PATH=" + os.path.join(DPCPP_ROOT, "bin", "clang"), | ||
| "-DCMAKE_CXX_COMPILER:PATH=" + os.path.join(DPCPP_ROOT, "bin", "clang++"), | ||
| backends, | ||
| ] | ||
| subprocess.check_call(cmake_args, stderr=subprocess.STDOUT, shell=False) | ||
| subprocess.check_call(["make", "-j", "4"]) | ||
| subprocess.check_call(["make", "V=1", "-j", "4"]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes improvements to our Cmake scripts and moves all the CMake changes out of #241 to this PR.
Summary of changes:
FindDPCPP.DPCTL_GENERATE_COVERAGEto enable coverage generation rules and dependencies.llvm-covandlcov-genhtml) to generate code coverage for the C API when configured with-DDPCTL_GENERATE_COVERAGE.make llvm-covto generate the summary report for code coverage usingllvm-cov. llvm-cov is part of standard LLVM tools and part of oneapi install.make lcov-genhtmlto generate a detailed html report for code coverage and missing segments of dpctl C API sources. Requireslcovto be installed on the system. Note that the new option-DDPCTL_COVERAGE_REPORT_OUTPUT_DIRcan be used to configure where the html files are saved. If nothing is specified, the report is saved in the build directory in a subdirectory calleddpctl-c-api-coverage.dpctl_config.hgets auto-generated in the install directory.