From dc8ce22ee3c2dc0f473ea26a1bb6be9c34c2d264 Mon Sep 17 00:00:00 2001 From: Sergey Pokhodenko Date: Sat, 20 Feb 2021 06:39:14 -0600 Subject: [PATCH 1/3] delete SyclProgram; --- dpctl-capi/source/dpctl_sycl_program_interface.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dpctl-capi/source/dpctl_sycl_program_interface.cpp b/dpctl-capi/source/dpctl_sycl_program_interface.cpp index 52faf48a04..52ad97db46 100644 --- a/dpctl-capi/source/dpctl_sycl_program_interface.cpp +++ b/dpctl-capi/source/dpctl_sycl_program_interface.cpp @@ -269,9 +269,11 @@ DPCTLProgram_CreateFromOCLSource(__dpctl_keep const DPCTLSyclContextRef Ctx, break; case backend::level_zero: std::cerr << "CreateFromSource is not supported in Level Zero.\n"; + delete SyclProgram; return nullptr; default: std::cerr << "CreateFromSource is not supported in unknown backend.\n"; + delete SyclProgram; return nullptr; } } From 81a637cba0f36272682e21c459fa3b909de76de4 Mon Sep 17 00:00:00 2001 From: Sergey Pokhodenko Date: Sat, 20 Feb 2021 06:46:10 -0600 Subject: [PATCH 2/3] DynamicLibHelper operator= delete. --- dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h b/dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h index 59e33b13d0..f2a2dd563d 100644 --- a/dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h +++ b/dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h @@ -46,6 +46,7 @@ namespace dpctl class DynamicLibHelper final { public: + DynamicLibHelper & operator=(const DynamicLibHelper&) = delete; DynamicLibHelper() = delete; DynamicLibHelper(const DynamicLibHelper &) = delete; DynamicLibHelper(const char *libName, int flag) From 87d74554ba26b7c162042f78275d2f1356705b85 Mon Sep 17 00:00:00 2001 From: Sergey Pokhodenko Date: Sat, 20 Feb 2021 08:52:20 -0600 Subject: [PATCH 3/3] Fix clang-format --- CONTRIBUTING.md | 2 +- dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a0de847880..74a47f54fa 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ We use [clang-format](https://clang.llvm.org/docs/ClangFormat.html) code formatter. -Install: `pip install clang` +Install: `conda install clang-tools` - Revision: `10.0.1` - See the default configuration used by dpCtl in `.clang-format`. diff --git a/dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h b/dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h index f2a2dd563d..32c84e22b6 100644 --- a/dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h +++ b/dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h @@ -46,7 +46,7 @@ namespace dpctl class DynamicLibHelper final { public: - DynamicLibHelper & operator=(const DynamicLibHelper&) = delete; + DynamicLibHelper &operator=(const DynamicLibHelper &) = delete; DynamicLibHelper() = delete; DynamicLibHelper(const DynamicLibHelper &) = delete; DynamicLibHelper(const char *libName, int flag)