Memory api #740
Merged
Memory api #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed functions to avoid name clashes for get_queue_ref/get_context_ref defined for different signatures. (C-API requires names to be different). Adjsuted tests to reflect changes in C-API names
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/740/index.html |
|
@oleksandr-pavlyk How do Python projects normally document a C API? Is there a way to generate meaningful docstrings for these functions and then have them on our documentation page? |
diptorupd
reviewed
Jan 7, 2022
diptorupd
reviewed
Jan 7, 2022
|
Good question, but I do not know the answer. Cython translates .pyx into C++, we could inject doxystring in there. Alternatively, we would document it separately (no in the implementation) |
oleksandr-pavlyk
force-pushed
the
memory_api
branch
from
804cd67 to
c771d1a
Compare
oleksandr-pavlyk
force-pushed
the
memory_api
branch
from
aee8da8 to
dae3902
Compare
|
@diptorupd This is good to go in from my standpoint. The summary of changes:
|
diptorupd
reviewed
Jan 13, 2022
diptorupd
reviewed
Jan 13, 2022
diptorupd
reviewed
Jan 13, 2022
diptorupd
reviewed
Jan 13, 2022
diptorupd
reviewed
Jan 13, 2022
diptorupd
approved these changes
Jan 24, 2022
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands Python C-API public functions to work with memory objects.
What is missing is pybind11 casters.