-
Notifications
You must be signed in to change notification settings - Fork 30
Memory api #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory api #740
Conversation
Renamed functions to avoid name clashes for get_queue_ref/get_context_ref defined for different signatures. (C-API requires names to be different). Adjsuted tests to reflect changes in C-API names
View rendered docs @ https://intelpython.github.io/dpctl/pulls/740/index.html |
@oleksandr-pavlyk How do Python projects normally document a C API? Is there a way to generate meaningful docstrings for these functions and then have them on our documentation page? |
Good question, but I do not know the answer. Cython translates .pyx into C++, we could inject doxystring in there. Alternatively, we would document it separately (no in the implementation) |
804cd67
to
c771d1a
Compare
aee8da8
to
dae3902
Compare
@diptorupd This is good to go in from my standpoint. The summary of changes:
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
This expands Python C-API public functions to work with memory objects.
What is missing is pybind11 casters.