From 86090ff4e0191342a2d561309bff8c66ebd7481b Mon Sep 17 00:00:00 2001 From: Oleksandr Pavlyk Date: Thu, 12 May 2022 20:14:53 -0700 Subject: [PATCH 1/2] fixed typo in variable name in assertion --- dpctl/tensor/libtensor/include/utils/type_dispatch.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dpctl/tensor/libtensor/include/utils/type_dispatch.hpp b/dpctl/tensor/libtensor/include/utils/type_dispatch.hpp index 3fbd4fb1d2..785a2157bb 100644 --- a/dpctl/tensor/libtensor/include/utils/type_dispatch.hpp +++ b/dpctl/tensor/libtensor/include/utils/type_dispatch.hpp @@ -80,7 +80,7 @@ class DispatchTableBuilder factory{}.get(), factory>{}.get(), factory>{}.get()}; - assert(per_dsTy.size() == _num_types); + assert(per_dstTy.size() == _num_types); return per_dstTy; } From 458c4eab85c3923bcb4781297125cd5f5dbda90d Mon Sep 17 00:00:00 2001 From: Oleksandr Pavlyk Date: Thu, 12 May 2022 20:15:42 -0700 Subject: [PATCH 2/2] Fixed compiler warnings from code in assertions, comparison of signed and unsigned types --- dpctl/tensor/libtensor/source/tensor_py.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/dpctl/tensor/libtensor/source/tensor_py.cpp b/dpctl/tensor/libtensor/source/tensor_py.cpp index 4ec925e50f..8d385c99b8 100644 --- a/dpctl/tensor/libtensor/source/tensor_py.cpp +++ b/dpctl/tensor/libtensor/source/tensor_py.cpp @@ -411,9 +411,9 @@ void simplify_iteration_space(int &nd, } } - assert(simplified_shape.size() == nd); - assert(simplified_src_strides.size() == nd); - assert(simplified_dst_strides.size() == nd); + assert(simplified_shape.size() == static_cast(nd)); + assert(simplified_src_strides.size() == static_cast(nd)); + assert(simplified_dst_strides.size() == static_cast(nd)); int contracted_nd = simplify_iteration_two_strides( nd, simplified_shape.data(), simplified_src_strides.data(), simplified_dst_strides.data(), @@ -472,9 +472,9 @@ void simplify_iteration_space(int &nd, simplified_dst_strides.push_back(dst_strides[0]); } - assert(simplified_shape.size() == nd); - assert(simplified_src_strides.size() == nd); - assert(simplified_dst_strides.size() == nd); + assert(simplified_shape.size() == static_cast(nd)); + assert(simplified_src_strides.size() == static_cast(nd)); + assert(simplified_dst_strides.size() == static_cast(nd)); } } @@ -1329,9 +1329,9 @@ void copy_numpy_ndarray_into_usm_ndarray( simplified_shape, simplified_src_strides, simplified_dst_strides, src_offset, dst_offset); - assert(simplified_shape.size() == nd); - assert(simplified_src_strides.size() == nd); - assert(simplified_dst_strides.size() == nd); + assert(simplified_shape.size() == static_cast(nd)); + assert(simplified_src_strides.size() == static_cast(nd)); + assert(simplified_dst_strides.size() == static_cast(nd)); // handle nd == 0 if (nd == 0) {