set CMAKE_FIND_ROOT_PATH_MODE_INCLUDE to BOTH #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

oleksandr-pavlyk merged 11 commits into master from fix-build-breakage-with-update-of-skbuild

Oct 5, 2022

Contributor

oleksandr-pavlyk commented Oct 1, 2022 •

edited

Loading

In scikit-build 0.14.0 -DCMAKE_FIND_PATH_MODE_INCLUDE=ONLY started being set. This breaks working of IntelDPCPP integration with cmake, since find_file then ignores specified paths and hints.

Setting the value in CMakeLists.txt overrides that value

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?


          set CMAKE_FIND_ROOT_PATH_MODE_INCLUDE to BOTH

6911b6f

In scikit-build 0.14.0 -DCMAKE_FIND_PATH_MODE_INCLUDE=ONLY started being
set. This breaks working of IntelDPCPP integration with cmake, since
find_file starts ignoring specified paths and hints.

Setting the value in CMakeLists.txt overrides that value

oleksandr-pavlyk requested review from diptorupd and AndresGuzman-Ballen

October 1, 2022 19:07

github-actions bot commented Oct 1, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/919/index.html

Collaborator

coveralls commented Oct 1, 2022 •

edited

Loading

Coverage remained the same at 82.01% when pulling 8b51053 on fix-build-breakage-with-update-of-skbuild into 880b0c3 on master.

oleksandr-pavlyk added 2 commits

October 1, 2022 14:38


          _onemkl example should link to OpenCL per link advisor

034ae1e


          Setting location of TBB_DLLs in cl.cfg

bdf126b

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from 9a113f3 to bdf126b Compare

October 2, 2022 19:08


          Use -c intel -c main for conda-packages.yml

27462c5

Also adjusted conda list command in test_linux section to
list content of test_dpctl environment

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from b08a374 to 27462c5 Compare

October 3, 2022 13:32

AndresGuzman-Ballen previously approved these changes

View reviewed changes

Contributor

AndresGuzman-Ballen left a comment

looks good to me!

oleksandr-pavlyk dismissed AndresGuzman-Ballen’s stale review via

059dc03

October 3, 2022 16:43

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from 059dc03 to 0a06c33 Compare

October 3, 2022 16:46


          Fixed empty LIBZE_LOADER_FILENAME and LIBCL_LOADER_FILENAME

fdf7835

Variables were set in the nested scope and not propagated to the
parent scope.

The config also has erroneous space before the trailing @ symbol.

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from 0a06c33 to fdf7835 Compare

October 3, 2022 16:49


          Set CMAKE_FIND_ROOT_PATH_MODE_LIBRARY to BOTH too

d8fc8dc

This is to ensure that find_library can find libpi_level_zero
and libpi_opencl

github-actions bot commented Oct 3, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_133.

github-actions bot commented Oct 3, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_134.

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from cb8829d to bfc2e8d Compare

October 3, 2022 19:48

github-actions bot commented Oct 3, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_134.

github-actions bot commented Oct 3, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_135.

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from a6fc1ed to 3d08d30 Compare

October 3, 2022 22:35

github-actions bot commented Oct 3, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_135.


          Fixing windows by using cmd shell to run tests

99e49c0

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from 3d08d30 to 99e49c0 Compare

October 3, 2022 23:58

github-actions bot commented Oct 4, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_134.


          Create workdir env var to use instead of GITHUB_WORKSPACE

8eb1c72

github-actions bot commented Oct 4, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_135.


          Copy ver.json only if does not exist

e838d95

github-actions bot commented Oct 4, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_137.

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from 42df655 to 2d819ea Compare

October 4, 2022 18:44

github-actions bot commented Oct 4, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_137.

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from 2d819ea to 885095e Compare

October 4, 2022 20:09

github-actions bot commented Oct 4, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_137.

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from 885095e to 4bec34e Compare

October 4, 2022 20:49

github-actions bot commented Oct 4, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_137.

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from 4bec34e to 99af96d Compare

October 4, 2022 21:23

github-actions bot commented Oct 4, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_137.

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from 99af96d to 9145eea Compare

October 4, 2022 21:51

github-actions bot commented Oct 4, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_137.


          Attempt to triage py38

8ee1d41

oleksandr-pavlyk force-pushed the fix-build-breakage-with-update-of-skbuild branch from 9145eea to 8ee1d41 Compare

October 4, 2022 22:41

github-actions bot commented Oct 4, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_137.


          Update conda-package.yml

8b51053

Use double quotes in Add library step to ensure it is expanded

github-actions bot commented Oct 5, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_138.

oleksandr-pavlyk merged commit b07d2d8 into master

oleksandr-pavlyk deleted the fix-build-breakage-with-update-of-skbuild branch

October 5, 2022 00:45

github-actions bot commented Oct 5, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions bot commented Oct 5, 2022

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_138.

oleksandr-pavlyk mentioned this pull request

Backport pr-919 to gold/2021 #930

Merged

5 tasks

oleksandr-pavlyk mentioned this pull request

Updated meta.yaml for 2022.1 sources AnacondaRecipes/intel-compilers-repack-feedstock#6

Closed

oleksandr-pavlyk added a commit that referenced this pull request


          Use conda-build-verson=*, fixed syntax for branching

0c749a8

Use of lower case 'if not exist ver.json' instead of
'IF NOT EXIST ver.json' was responsible to a silent failure
to retrieve specification of build dpctl that went unnoticed
since gh-919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet