From b287592bde335c319f81ca0dff6d9729aa4aa5cb Mon Sep 17 00:00:00 2001 From: Anton Volkov Date: Mon, 14 Jul 2025 17:31:20 +0200 Subject: [PATCH 1/4] Add job explicit, conservative job timeouts --- .github/workflows/build-sphinx.yml | 2 ++ .github/workflows/check-onemath.yaml | 3 +++ .github/workflows/conda-package.yml | 6 ++++++ .github/workflows/cron-run-tests.yaml | 1 + .github/workflows/generate_coverage.yaml | 3 +++ .github/workflows/openssf-scorecard.yml | 1 + .github/workflows/pre-commit.yml | 6 +++++- 7 files changed, 21 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-sphinx.yml b/.github/workflows/build-sphinx.yml index 83ba6c3db44..264f7d04f70 100644 --- a/.github/workflows/build-sphinx.yml +++ b/.github/workflows/build-sphinx.yml @@ -26,6 +26,7 @@ jobs: name: Build and Deploy Docs runs-on: ubuntu-22.04 + timeout-minutes: 60 permissions: # Needed to cancel any previous runs that are not completed for a given workflow @@ -244,6 +245,7 @@ jobs: pull-requests: write runs-on: ubuntu-latest + timeout-minutes: 10 steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 diff --git a/.github/workflows/check-onemath.yaml b/.github/workflows/check-onemath.yaml index 0b17fb9b473..6ad8f817983 100644 --- a/.github/workflows/check-onemath.yaml +++ b/.github/workflows/check-onemath.yaml @@ -29,6 +29,7 @@ jobs: actions: write runs-on: 'ubuntu-latest' + timeout-minutes: 5 steps: - name: Cancel Previous Runs @@ -69,6 +70,7 @@ jobs: os: [ubuntu-22.04] # windows-2022 - no DFT support for Windows in oneMKL runs-on: ${{ matrix.os }} + timeout-minutes: 60 defaults: run: @@ -157,6 +159,7 @@ jobs: os: [ubuntu-22.04] # windows-2022 - no DFT support for Windows in oneMKL runs-on: ${{ matrix.os }} + timeout-minutes: 60 defaults: run: diff --git a/.github/workflows/conda-package.yml b/.github/workflows/conda-package.yml index 8652a36fedc..e415fcfdc39 100644 --- a/.github/workflows/conda-package.yml +++ b/.github/workflows/conda-package.yml @@ -37,6 +37,7 @@ jobs: actions: write runs-on: ${{ matrix.os }} + timeout-minutes: 60 defaults: run: @@ -118,6 +119,7 @@ jobs: needs: build runs-on: ${{ matrix.os }} + timeout-minutes: 60 defaults: run: @@ -245,6 +247,7 @@ jobs: needs: build runs-on: ${{ matrix.os }} + timeout-minutes: 120 defaults: run: @@ -406,6 +409,7 @@ jobs: os: [ubuntu-22.04, windows-2022] runs-on: ${{ matrix.os }} + timeout-minutes: 10 defaults: run: @@ -487,6 +491,7 @@ jobs: os: [ubuntu-22.04] runs-on: ${{ matrix.os }} + timeout-minutes: 15 defaults: run: @@ -649,6 +654,7 @@ jobs: needs: [upload] runs-on: 'ubuntu-latest' + timeout-minutes: 10 defaults: run: diff --git a/.github/workflows/cron-run-tests.yaml b/.github/workflows/cron-run-tests.yaml index a25903e71aa..4d164ccdef3 100644 --- a/.github/workflows/cron-run-tests.yaml +++ b/.github/workflows/cron-run-tests.yaml @@ -26,6 +26,7 @@ jobs: if: github.event.repository.fork == false runs-on: ${{ matrix.runner }} + timeout-minutes: 60 defaults: run: diff --git a/.github/workflows/generate_coverage.yaml b/.github/workflows/generate_coverage.yaml index 438394eaa62..de1aba575a4 100644 --- a/.github/workflows/generate_coverage.yaml +++ b/.github/workflows/generate_coverage.yaml @@ -9,7 +9,9 @@ permissions: read-all jobs: generate-coverage: name: Generate coverage and push to Coveralls.io + runs-on: ubuntu-latest + timeout-minutes: 120 permissions: # Needed to cancel any previous runs that are not completed for a given workflow @@ -154,6 +156,7 @@ jobs: needs: generate-coverage runs-on: ubuntu-latest + timeout-minutes: 10 container: python:3-slim diff --git a/.github/workflows/openssf-scorecard.yml b/.github/workflows/openssf-scorecard.yml index 2013a72ba3c..363418c5239 100644 --- a/.github/workflows/openssf-scorecard.yml +++ b/.github/workflows/openssf-scorecard.yml @@ -22,6 +22,7 @@ jobs: analysis: name: Scorecard analysis runs-on: ubuntu-latest + timeout-minutes: 10 permissions: # Needed to upload the results to code-scanning dashboard. security-events: write diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index f0a078611ed..069780e7d90 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -1,4 +1,4 @@ -name: pre-commit +name: Run pre-commit on: pull_request: @@ -9,7 +9,11 @@ permissions: read-all jobs: pre-commit: + name: Check + runs-on: ubuntu-22.04 + timeout-minutes: 10 + steps: - name: Set up clang-format run: | From a9d6ea024bb1ed24415391d371e3df122410d31f Mon Sep 17 00:00:00 2001 From: Anton Volkov Date: Mon, 14 Jul 2025 17:37:04 +0200 Subject: [PATCH 2/4] Add PR to the changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5918ade03f3..11d1aa2e5d4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 * Added several new `pre-commit` rules, including protection against direct commits to master/maintenance branches [#2500](https://github.com/IntelPython/dpnp/pull/2500) * Added implementation of `dpnp.ndarray.view` method [#2520](https://github.com/IntelPython/dpnp/pull/2520) * Added a new backend routine `syrk` from oneMKL to perform symmetric rank-k update which is used for a specialized matrix multiplication where the result is a symmetric matrix [2509](https://github.com/IntelPython/dpnp/pull/2509) +* Added `timeout-minutes` property GitHub jobs [#2526](https://github.com/IntelPython/dpnp/pull/2526) ### Changed From 39ffeae2218c29b0b38f52133cfc6f564aa1b842 Mon Sep 17 00:00:00 2001 From: Anton <100830759+antonwolfy@users.noreply.github.com> Date: Mon, 14 Jul 2025 19:00:12 +0200 Subject: [PATCH 3/4] Update CHANGELOG.md Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 11d1aa2e5d4..228e80eaeb8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 * Added several new `pre-commit` rules, including protection against direct commits to master/maintenance branches [#2500](https://github.com/IntelPython/dpnp/pull/2500) * Added implementation of `dpnp.ndarray.view` method [#2520](https://github.com/IntelPython/dpnp/pull/2520) * Added a new backend routine `syrk` from oneMKL to perform symmetric rank-k update which is used for a specialized matrix multiplication where the result is a symmetric matrix [2509](https://github.com/IntelPython/dpnp/pull/2509) -* Added `timeout-minutes` property GitHub jobs [#2526](https://github.com/IntelPython/dpnp/pull/2526) +* Added `timeout-minutes` property to GitHub jobs [#2526](https://github.com/IntelPython/dpnp/pull/2526) ### Changed From 2449be6bee336db4ecb27b6de66fb739c2824d61 Mon Sep 17 00:00:00 2001 From: Anton Volkov Date: Mon, 14 Jul 2025 19:59:43 +0200 Subject: [PATCH 4/4] Increase timeout for running tests on Linux --- .github/workflows/conda-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/conda-package.yml b/.github/workflows/conda-package.yml index e415fcfdc39..b6d9b156b29 100644 --- a/.github/workflows/conda-package.yml +++ b/.github/workflows/conda-package.yml @@ -119,7 +119,7 @@ jobs: needs: build runs-on: ${{ matrix.os }} - timeout-minutes: 60 + timeout-minutes: 100 defaults: run: