Skip to content

Commit 96d4b2f

Browse files
matejcikMariatta
authored andcommitted
update test_socket AEAD test for kernel 4.9 and up (python#133)
(cherry picked from commit 9764c15)
1 parent d8b72e4 commit 96d4b2f

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

Lib/test/test_socket.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5469,7 +5469,7 @@ def test_aes_cbc(self):
54695469
self.assertEqual(len(dec), msglen * multiplier)
54705470
self.assertEqual(dec, msg * multiplier)
54715471

5472-
@support.requires_linux_version(4, 3) # see test_aes_cbc
5472+
@support.requires_linux_version(4, 9) # see issue29324
54735473
def test_aead_aes_gcm(self):
54745474
key = bytes.fromhex('c939cc13397c1d37de6ae0e1cb7c423c')
54755475
iv = bytes.fromhex('b3d8cc017cbb89b39e0f67e2')
@@ -5492,16 +5492,15 @@ def test_aead_aes_gcm(self):
54925492
op.sendmsg_afalg(op=socket.ALG_OP_ENCRYPT, iv=iv,
54935493
assoclen=assoclen, flags=socket.MSG_MORE)
54945494
op.sendall(assoc, socket.MSG_MORE)
5495-
op.sendall(plain, socket.MSG_MORE)
5496-
op.sendall(b'\x00' * taglen)
5495+
op.sendall(plain)
54975496
res = op.recv(assoclen + len(plain) + taglen)
54985497
self.assertEqual(expected_ct, res[assoclen:-taglen])
54995498
self.assertEqual(expected_tag, res[-taglen:])
55005499

55015500
# now with msg
55025501
op, _ = algo.accept()
55035502
with op:
5504-
msg = assoc + plain + b'\x00' * taglen
5503+
msg = assoc + plain
55055504
op.sendmsg_afalg([msg], op=socket.ALG_OP_ENCRYPT, iv=iv,
55065505
assoclen=assoclen)
55075506
res = op.recv(assoclen + len(plain) + taglen)
@@ -5512,15 +5511,15 @@ def test_aead_aes_gcm(self):
55125511
pack_uint32 = struct.Struct('I').pack
55135512
op, _ = algo.accept()
55145513
with op:
5515-
msg = assoc + plain + b'\x00' * taglen
5514+
msg = assoc + plain
55165515
op.sendmsg(
55175516
[msg],
55185517
([socket.SOL_ALG, socket.ALG_SET_OP, pack_uint32(socket.ALG_OP_ENCRYPT)],
55195518
[socket.SOL_ALG, socket.ALG_SET_IV, pack_uint32(len(iv)) + iv],
55205519
[socket.SOL_ALG, socket.ALG_SET_AEAD_ASSOCLEN, pack_uint32(assoclen)],
55215520
)
55225521
)
5523-
res = op.recv(len(msg))
5522+
res = op.recv(len(msg) + taglen)
55245523
self.assertEqual(expected_ct, res[assoclen:-taglen])
55255524
self.assertEqual(expected_tag, res[-taglen:])
55265525

@@ -5530,8 +5529,8 @@ def test_aead_aes_gcm(self):
55305529
msg = assoc + expected_ct + expected_tag
55315530
op.sendmsg_afalg([msg], op=socket.ALG_OP_DECRYPT, iv=iv,
55325531
assoclen=assoclen)
5533-
res = op.recv(len(msg))
5534-
self.assertEqual(plain, res[assoclen:-taglen])
5532+
res = op.recv(len(msg) - taglen)
5533+
self.assertEqual(plain, res[assoclen:])
55355534

55365535
@support.requires_linux_version(4, 3) # see test_aes_cbc
55375536
def test_drbg_pr_sha256(self):

0 commit comments

Comments
 (0)