remove unused arg in gv_fetchfile_flags

Since gv_fetchfile_flags was created in commit d9095ce in 5.9.5 in 2007
the flags argument has been unused and undefined as to its meaning.
Remove the cpu instruction overhead of pushing the flags arg in the
callers of gv_fetchfile_flags by changing it to a macro that drops out
the flags argument. Only known callers are NYTProf and core's gv_fetchfile
according to cpan grep. This commits sets up future refactoring of
gv_fetchfile*.

Author: bulk88

embed.fnc

@@ -505,8 +505,9 @@ Ap	|void	|gv_efullname	|NN SV* sv|NN const GV* gv
 Apmb	|void	|gv_efullname3	|NN SV* sv|NN const GV* gv|NULLOK const char* prefix
 Ap	|void	|gv_efullname4	|NN SV* sv|NN const GV* gv|NULLOK const char* prefix|bool keepmain
 Ap	|GV*	|gv_fetchfile	|NN const char* name
-Ap	|GV*	|gv_fetchfile_flags|NN const char *const name|const STRLEN len\
+Am	|GV*	|gv_fetchfile_flags|NN const char *const name|const STRLEN len\
 				|const U32 flags
+pX	|GV*	|gv_fetchfile_x|NN const char *const name|const STRLEN len
 Amd	|GV*	|gv_fetchmeth	|NULLOK HV* stash|NN const char* name \
 				|STRLEN len|I32 level
 Apd	|GV*	|gv_fetchmeth_sv	|NULLOK HV* stash|NN SV* namesv|I32 level|U32 flags

embed.h

@@ -193,7 +193,6 @@
 #define gv_efullname(a,b)	Perl_gv_efullname(aTHX_ a,b)
 #define gv_efullname4(a,b,c,d)	Perl_gv_efullname4(aTHX_ a,b,c,d)
 #define gv_fetchfile(a)		Perl_gv_fetchfile(aTHX_ a)
-#define gv_fetchfile_flags(a,b,c)	Perl_gv_fetchfile_flags(aTHX_ a,b,c)
 #define gv_fetchmeth_pv(a,b,c,d)	Perl_gv_fetchmeth_pv(aTHX_ a,b,c,d)
 #define gv_fetchmeth_pv_autoload(a,b,c,d)	Perl_gv_fetchmeth_pv_autoload(aTHX_ a,b,c,d)
 #define gv_fetchmeth_pvn(a,b,c,d,e)	Perl_gv_fetchmeth_pvn(aTHX_ a,b,c,d,e)
@@ -1221,6 +1220,7 @@
 #define get_hash_seed(a)	Perl_get_hash_seed(aTHX_ a)
 #define get_no_modify()		Perl_get_no_modify(aTHX)
 #define get_opargs()		Perl_get_opargs(aTHX)
+#define gv_fetchfile_x(a,b)	Perl_gv_fetchfile_x(aTHX_ a,b)
 #define gv_override(a,b)	Perl_gv_override(aTHX_ a,b)
 #define gv_setref(a,b)		Perl_gv_setref(aTHX_ a,b)
 #define gv_try_downgrade(a)	Perl_gv_try_downgrade(aTHX_ a)

gv.c

@@ -98,16 +98,14 @@ Perl_gv_fetchfile(pTHX_ const char *name)
 }
 
 GV *
-Perl_gv_fetchfile_flags(pTHX_ const char *const name, const STRLEN namelen,
-			const U32 flags)
+Perl_gv_fetchfile_x(pTHX_ const char *const name, const STRLEN namelen)
 {
     char smallbuf[128];
     char *tmpbuf;
     const STRLEN tmplen = namelen + 2;
     GV *gv;
 
-    PERL_ARGS_ASSERT_GV_FETCHFILE_FLAGS;
-    PERL_UNUSED_ARG(flags);
+    PERL_ARGS_ASSERT_GV_FETCHFILE_X;
 
     if (!PL_defstash)
 	return NULL;

gv.h

@@ -265,6 +265,7 @@ Return the CV from the GV.
 #define gv_fetchmeth(stash,name,len,level) gv_fetchmeth_pvn(stash, name, len, level, 0)
 #define gv_fetchmeth_autoload(stash,name,len,level) gv_fetchmeth_pvn_autoload(stash, name, len, level, 0)
 #define gv_fetchmethod_flags(stash,name,flags) gv_fetchmethod_pv_flags(stash, name, flags)
+#define gv_fetchfile_flags(name,len,flags) Perl_gv_fetchfile_x(aTHX_ name,len)
 #define gv_autoload4(stash, name, len, method) \
 	gv_autoload_pvn(stash, name, len, !!(method))
 #define newGVgen(pack)  newGVgen_flags(pack, 0)

proto.h

@@ -1018,8 +1018,9 @@ PERL_CALLCONV void	Perl_gv_efullname4(pTHX_ SV* sv, const GV* gv, const char* pr
 PERL_CALLCONV GV*	Perl_gv_fetchfile(pTHX_ const char* name);
 #define PERL_ARGS_ASSERT_GV_FETCHFILE	\
 	assert(name)
-PERL_CALLCONV GV*	Perl_gv_fetchfile_flags(pTHX_ const char *const name, const STRLEN len, const U32 flags);
-#define PERL_ARGS_ASSERT_GV_FETCHFILE_FLAGS	\
+/* PERL_CALLCONV GV*	gv_fetchfile_flags(pTHX_ const char *const name, const STRLEN len, const U32 flags); */
+PERL_CALLCONV GV*	Perl_gv_fetchfile_x(pTHX_ const char *const name, const STRLEN len);
+#define PERL_ARGS_ASSERT_GV_FETCHFILE_X	\
 	assert(name)
 /* PERL_CALLCONV GV*	gv_fetchmeth(pTHX_ HV* stash, const char* name, STRLEN len, I32 level); */
 /* PERL_CALLCONV GV*	gv_fetchmeth_autoload(pTHX_ HV* stash, const char* name, STRLEN len, I32 level); */