Skip to content

PR 3074 somehow breaks hyper-letters (hyper terminal plugin) on Mac #3267

@corbob

Description

@corbob

Prerequisites

  • Write a descriptive title.
  • Make sure you are able to repro it on the latest released version
  • Search the existing issues, especially the pinned issues.

Exception report

N/A

Screenshot

2022-04-09_17-32-36 (1)

Environment data

PS Version: 7.2.2
PS HostName: ConsoleHost
PSReadLine Version: 2.2.2
PSReadLine EditMode: Emacs
OS: Darwin Corys-MacBook-Pro.local 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:45:05 PDT 2022; root:xnu-8020.101.4~15/RELEASE_X86_64 x86_64
BufferWidth: 200
BufferHeight: 80

Steps to reproduce

On a mac:

  1. Install hyper
  2. Install hyper-letter (hyper install hyper-letter)
  3. Notice that letters fall only when PSReadLine is not active

NOTE: I found that this was related to #3074 by tracking it down to working in 2.2.0-beta4 but not 2.2.0-beta5, then with the PRs included in beta5 just running git revert <merge commit hash> and seeing if the issue was resolved. I have verified that working off of develop, reverting #3074 resolves this issue for me, but haven't tested anything else.

Expected behavior

Letters fall as they're typed.

Actual behavior

No letters produced.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions