From 8d6ffab3e9a86a5bfc5378402e041cea8d047f9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Collonval?= Date: Mon, 7 Sep 2020 13:40:18 +0200 Subject: [PATCH 1/2] Correct hidden folder removal The first fix to remove hidden folder was not working properly in case multiple hidden folders exist. --- jupyterlab-snippets/loader.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jupyterlab-snippets/loader.py b/jupyterlab-snippets/loader.py index 0fae614..93f2d08 100644 --- a/jupyterlab-snippets/loader.py +++ b/jupyterlab-snippets/loader.py @@ -15,10 +15,10 @@ def collect_snippets(self): snippets = [] for root_path in self.snippet_paths: for dirpath, dirnames, filenames in os.walk(root_path, followlinks=True): - # Remove hidden folder - for folder_i, folder in enumerate(dirnames): - if folder.startswith("."): - dirnames.pop(folder_i) + # Remove hidden folder + to_remove = [folder for folder in dirnames if folder.startswith(".")] + for folder in to_remove: + dirnames.remove(folder) for f in filenames: fullpath = PurePath(dirpath).relative_to(root_path).joinpath(f) From 414d37989ec40ca102436841cc6e6c591a2675b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Collonval?= Date: Mon, 7 Sep 2020 13:41:08 +0200 Subject: [PATCH 2/2] Remove trailing whitespace --- jupyterlab-snippets/loader.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jupyterlab-snippets/loader.py b/jupyterlab-snippets/loader.py index 93f2d08..ee9a741 100644 --- a/jupyterlab-snippets/loader.py +++ b/jupyterlab-snippets/loader.py @@ -15,7 +15,7 @@ def collect_snippets(self): snippets = [] for root_path in self.snippet_paths: for dirpath, dirnames, filenames in os.walk(root_path, followlinks=True): - # Remove hidden folder + # Remove hidden folder to_remove = [folder for folder in dirnames if folder.startswith(".")] for folder in to_remove: dirnames.remove(folder)