Skip to content

Commit 8cca664

Browse files
HaudinFlorenceHaudinFlorence
committed
Take review comments into account.
1 parent 01155bd commit 8cca664

File tree

5 files changed

+46
-45
lines changed

5 files changed

+46
-45
lines changed

‎src/components/about/LargePortraitCard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export function Distinction({ person }) {
1313
{HasPersonDistinction ? (
1414
<ul style={{paddingLeft: "0px"}}>
1515
{person.distinctionTitle.map((distinction, index) => (
16-
<li className="items-list" key={person.firstName}>
16+
<li className="items-list" key={person.pageName}>
1717
<div>
1818
<Link href={person.distinctionLink[index]}>
1919
<DistinctionIcon className={styles.distinction_icon} />

‎src/components/about/LargePortraitCardPage.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { useEffect } from 'react';
55
import { Route } from 'react-router-dom';
66
import { About } from '@site/src/components/about'
77
import LargePortraitCard from '@site/src/components/about/LargePortraitCard';
8-
import { getTeamByPersonName } from '@site/src/components/about';
8+
import { getTeamByPageName } from '@site/src/components/about';
99
import styles from "@site/src/components/about/styles.module.css";
1010

1111
export default function LargePortraitCardPage() {
@@ -46,11 +46,11 @@ export default function LargePortraitCardPage() {
4646
<Layout>
4747
<About />
4848
<Route
49-
path="/about/:completeName"
50-
render={({ history, match }) => {
51-
const { completeName } = match.params; /* extract the dynamic part from the url i.e. the completeName*/
52-
const teamMembers = getTeamByPersonName(completeName);
53-
const person = teamMembers.find((person) => person.completeName.replace(/\s+/g, '').normalize("NFD").replace(/[\u0300-\u036f]/g, '') === completeName);
49+
path="/about/:pageName"
50+
render={({ match }) => {
51+
const { pageName } = match.params; /* extract the dynamic part from the url i.e. the pageName*/
52+
const teamMembers = getTeamByPageName(pageName);
53+
const person = teamMembers.find((person) => person.pageName== pageName);
5454
if (!person) return null;
5555

5656
return (

‎src/components/about/SubTeam.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export default function SubTeam({ subTeamName, subTeam }) {
88
<div className={"container"}>
99
<ul className="row padding-none flex-full-centered row-with-margin-top">
1010
{subTeam.map((person, index) => (
11-
<li className="cards-list" key={person.firstName}>
11+
<li className="cards-list" key={person.pageName}>
1212
<div className="col">
1313
<SmallPortraitCard person={person} />
1414
</div>

‎src/components/about/Team/team.ts

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export const teams = {
7373
coreTeam: [
7474
{
7575
completeName: "Thorsten Beier",
76-
firstName: "Thorsten",
76+
pageName: "ThorstenBeier",
7777
position: "Scientific Software Developer",
7878
GitHubLink: "https://github.com/DerThorsten",
7979
LinkedInLink: "https://www.linkedin.com/in/thorsten-beier-95b121189/",
@@ -88,7 +88,7 @@ export const teams = {
8888
},
8989
{
9090
completeName: " Andreas Trawöger",
91-
firstName: "Andreas",
91+
pageName: "AndreasTrawoger",
9292
position: "DevOps Engineer",
9393
GitHubLink: "https://github.com/atrawog",
9494
LinkedInLink: "",
@@ -103,7 +103,7 @@ export const teams = {
103103
},
104104
{
105105
completeName: "Denisa Checiu",
106-
firstName: "Denisa",
106+
pageName: "DenisaCheciu",
107107
position: "Scientific Software Developer",
108108
GitHubLink: "https://github.com/DenisaCG",
109109
LinkedInLink: "https://www.linkedin.com/in/denisa-checiu-georgiana/",
@@ -118,7 +118,7 @@ export const teams = {
118118
},
119119
{
120120
completeName: "Joël Lamotte",
121-
firstName: "Joel",
121+
pageName: "JoelLamotte",
122122
position: "Scientific Software Developer",
123123
GitHubLink: "https://github.com/Klaim",
124124
LinkedInLink: "https://www.linkedin.com/in/a-jo%C3%ABl-lamotte-a5b09b85/",
@@ -133,7 +133,7 @@ export const teams = {
133133
},
134134
{
135135
completeName: "Florence Haudin",
136-
firstName: "Florence",
136+
pageName: "FlorenceHaudin",
137137
position: "Scientific Software Developer",
138138
GitHubLink: "https://github.com/HaudinFlorence",
139139
LinkedInLink: "https://www.linkedin.com/in/florence-haudin-fr/",
@@ -148,7 +148,7 @@ export const teams = {
148148
},
149149
{
150150
completeName: "Nicolas Brichet",
151-
firstName: "Nicolas",
151+
pageName: "NicolasBrichet",
152152
position: "Scientific Software Developer",
153153
GitHubLink: "https://github.com/brichet",
154154
LinkedInLink: "https://www.linkedin.com/in/nicolas-brichet-a26369150/",
@@ -163,7 +163,7 @@ export const teams = {
163163
},
164164
{
165165
completeName: "Isabel Paredes",
166-
firstName: "Isabel",
166+
pageName: "IsabelParedes",
167167
position: "Scientific Software Developer",
168168
GitHubLink: "https://github.com/ihuicatl",
169169
LinkedInLink: "https://www.linkedin.com/in/isabel-paredes/",
@@ -178,7 +178,7 @@ export const teams = {
178178
},
179179
{
180180
completeName: "Gabriela Vives",
181-
firstName: "Gabriela",
181+
pageName: "GabrielaVives",
182182
position: "User Experience Researcher and Designer",
183183
GitHubLink: "https://github.com/GabrielaVives",
184184
LinkedInLink: "https://www.linkedin.com/in/gabriela-vives-831ba853/",
@@ -193,7 +193,7 @@ export const teams = {
193193
},
194194
{
195195
completeName: "Hind Montassif",
196-
firstName: "Hind",
196+
pageName: "HindMontassif",
197197
position: "Scientific Software Developer",
198198
GitHubLink: "https://github.com/Hind-M",
199199
LinkedInLink: "https://www.linkedin.com/in/hindmontassif/",
@@ -208,7 +208,7 @@ export const teams = {
208208
},
209209
{
210210
completeName: "Julien Jerphanion",
211-
firstName: "Julien",
211+
pageName: "JulienJerphanion",
212212
position: "Scientific Software Developer",
213213
GitHubLink: "https://github.com/jjerphan",
214214
LinkedInLink: "https://www.linkedin.com/in/jjerphan/",
@@ -223,7 +223,7 @@ export const teams = {
223223
},
224224
{
225225
completeName: "Anutosh Bhat",
226-
firstName: "Anutosh",
226+
pageName: "AnutoshBhat",
227227
position: "Scientific Software Developer",
228228
GitHubLink: "https://github.com/anutosh491",
229229
LinkedInLink: "https://www.linkedin.com/in/anutosh-bhat-66ba961a8/",
@@ -238,7 +238,7 @@ export const teams = {
238238
},
239239
{
240240
completeName: "Greg Mooney",
241-
firstName: "Greg",
241+
pageName: "GregMooney",
242242
position: "Scientific Software Developer",
243243
GitHubLink: "https://github.com/gjmooney",
244244
LinkedInLink: "https://www.linkedin.com/in/gjmooney/",
@@ -253,7 +253,7 @@ export const teams = {
253253
},
254254
{
255255
completeName: "Ian Thomas",
256-
firstName: "Ian",
256+
pageName: "IanThomas",
257257
position: "Scientific Software Developer",
258258
GitHubLink: "https://github.com/ianthomas23",
259259
LinkedInLink: "https://www.linkedin.com/in/ian-thomas-796814240/",
@@ -268,7 +268,7 @@ export const teams = {
268268
},
269269
{
270270
completeName: "Meriem Ben Ismail",
271-
firstName: "Meriem",
271+
pageName: "MeriemBenIsmail",
272272
position: " Scientific Software Developer",
273273
GitHubLink: "https://github.com/Meriem-BenIsmail",
274274
LinkedInLink: "https://www.linkedin.com/in/meriem-ben-ismail-163042230/",
@@ -283,7 +283,7 @@ export const teams = {
283283
},
284284
{
285285
completeName: "Alexis Placet",
286-
firstName: "Alexis",
286+
pageName: "AlexisPlacet",
287287
position: " Scientific Software Developer",
288288
GitHubLink: "https://github.com/Alex-PLACET",
289289
LinkedInLink: "https://www.linkedin.com/in/alexisplacet/",
@@ -298,7 +298,7 @@ export const teams = {
298298
},
299299
{
300300
completeName: "Anastasiia Sliusar",
301-
firstName: "Anastasiia",
301+
pageName: "AnastasiiaSliusar",
302302
position: " Scientific Software Developer",
303303
GitHubLink: "https://github.com/AnastasiaSliusar",
304304
LinkedInLink: "https://www.linkedin.com/in/anastasiiasliusar-bellis/",
@@ -313,7 +313,7 @@ export const teams = {
313313
},
314314
{
315315
completeName: "Arjun Verma",
316-
firstName: "Arjun",
316+
pageName: "ArjunVerma",
317317
position: " Scientific Software Development Intern",
318318
GitHubLink: "https://github.com/arjxn-py",
319319
LinkedInLink:
@@ -329,7 +329,7 @@ export const teams = {
329329
},
330330
{
331331
completeName: "Sandrine Pataut",
332-
firstName: "Sandrine",
332+
pageName: "SandrinePataut",
333333
position: " Scientific Software Developer",
334334
GitHubLink: "https://github.com/SandrineP",
335335
LinkedInLink:
@@ -345,7 +345,7 @@ export const teams = {
345345
},
346346
{
347347
completeName: "Raúl Cumplido",
348-
firstName: "Raúl",
348+
pageName: "RaulCumplido",
349349
position: " Scientific Software Developer",
350350
GitHubLink: "https://github.com/raulcd",
351351
LinkedInLink:
@@ -361,7 +361,7 @@ export const teams = {
361361
},
362362
{
363363
completeName: "Antoine Prouvost",
364-
firstName: "Antoine",
364+
pageName: "AntoineProuvost",
365365
position: " Scientific Software Developer",
366366
GitHubLink: "https://github.com/AntoinePrv",
367367
LinkedInLink: "https://www.linkedin.com/in/antoine-prouvost-0667b6a4/",
@@ -376,7 +376,7 @@ export const teams = {
376376
},
377377
{
378378
completeName: "Yahia Heni",
379-
firstName: "Yahia",
379+
pageName: "YahiaHeni",
380380
position: " Scientific Software Development Intern",
381381
GitHubLink: "https://github.com/Yahiewi",
382382
LinkedInLink:
@@ -390,7 +390,7 @@ export const teams = {
390390
},
391391
{
392392
completeName: "Ousema Bouaneni",
393-
firstName: "Ousema",
393+
pageName: "OusemaBouaneni",
394394
position: " Scientific Software Development Intern",
395395
GitHubLink: "https://github.com/ousema-bouaneni",
396396
LinkedInLink:
@@ -404,7 +404,7 @@ export const teams = {
404404
},
405405
{
406406
completeName: "Guy Mushiata Kibulu",
407-
firstName: "Guy",
407+
pageName: "GuyMushiataKibulu",
408408
position: "Scientific Software Development Intern",
409409
GitHubLink: "https://github.com/Gauss-Taylor-Euler",
410410
LinkedInLink:
@@ -421,7 +421,7 @@ export const teams = {
421421
QSCollaboratorsTeam: [
422422
{
423423
completeName: "Johan Mabille",
424-
firstName: "Johan",
424+
pageName: "JohanMabille",
425425
position: "Technical Director",
426426
GitHubLink: "https://github.com/JohanMabille",
427427
LinkedInLink: "https://www.linkedin.com/in/johan-mabille/",
@@ -436,7 +436,7 @@ export const teams = {
436436
},
437437
{
438438
completeName: "Serge Guelton",
439-
firstName: "Serge",
439+
pageName: "SergeGuelton",
440440
position: "Scientific Software Developer",
441441
GitHubLink: "https://github.com/serge-sans-paille",
442442
LinkedInLink: "",
@@ -451,7 +451,7 @@ export const teams = {
451451
},
452452
{
453453
completeName: "Romain Menegaux",
454-
firstName: "Romain",
454+
pageName: "RomainMenegaux",
455455
position: "Scientific Software Developer",
456456
GitHubLink: "https://github.com/rmenegaux",
457457
LinkedInLink: "https://www.linkedin.com/in/romain-menegaux-88a147134/",
@@ -466,7 +466,7 @@ export const teams = {
466466
},
467467
{
468468
completeName: "Antoine Pitrou",
469-
firstName: "Antoine",
469+
pageName: "AntoinePitrou",
470470
position: "Senior Software Developer",
471471
GitHubLink: "https://github.com/pitrou",
472472
LinkedInLink:
@@ -482,7 +482,7 @@ export const teams = {
482482
},
483483
{
484484
completeName: "Marion Chaffaut",
485-
firstName: "Marion",
485+
pageName: "MarionChauffaut",
486486
position: "Chief Financial Officer",
487487
GitHubLink: "https://github.com/MarionChaff",
488488
LinkedInLink: "https://www.linkedin.com/in/marion-chaffaut/",
@@ -500,7 +500,7 @@ export const teams = {
500500
leadershipTeam: [
501501
{
502502
completeName: "Sylvain Corlay",
503-
firstName: "Sylvain",
503+
pageName: "SylvainCorlay",
504504
position: "Chief Executive Officer",
505505
GitHubLink: "https://github.com/SylvainCorlay",
506506
LinkedInLink: "https://www.linkedin.com/sylvaincorlay/?locale=en_US",
@@ -515,7 +515,7 @@ export const teams = {
515515
},
516516
{
517517
completeName: "Martin Renou",
518-
firstName: "Martin",
518+
pageName: "MartinRenou",
519519
position: "Technical Director",
520520
GitHubLink: "https://github.com/martinRenou",
521521
LinkedInLink: "https://www.linkedin.com/in/martin-renou",
@@ -530,7 +530,7 @@ export const teams = {
530530
},
531531
{
532532
completeName: "Jeremy Tuloup",
533-
firstName: "Jeremy",
533+
pageName: "JeremyTuloup",
534534
position: "Technical Director",
535535
GitHubLink: "https://github.com/jtpio",
536536
LinkedInLink: "https://www.linkedin.com/in/jtuloup/",
@@ -545,7 +545,7 @@ export const teams = {
545545
},
546546
{
547547
completeName: "Afshin Darian",
548-
firstName: "Darian",
548+
pageName: "AfshinDarian",
549549
position: "Technical Director",
550550
GitHubLink: "https://github.com/afshin",
551551
LinkedInLink: "https://www.linkedin.com/in/afshindarian/",
@@ -560,7 +560,7 @@ export const teams = {
560560
},
561561
{
562562
completeName: "David Brochart",
563-
firstName: "David",
563+
pageName: "DavidBrochart",
564564
position: "Technical Director",
565565
GitHubLink: "https://github.com/davidbrochart",
566566
LinkedInLink: "https://www.linkedin.com/in/david-brochart-4208721/",
@@ -575,7 +575,7 @@ export const teams = {
575575
},
576576
{
577577
completeName: "Matthias Meschede",
578-
firstName: "Matthias",
578+
pageName: "MatthiasMeschede",
579579
position: "Chief Operating Officer",
580580
GitHubLink: "https://github.com/mmesch",
581581
LinkedInLink: "https://www.linkedin.com/in/mmesch/",
@@ -590,7 +590,7 @@ export const teams = {
590590
},
591591
{
592592
completeName: "Le Duc Trung",
593-
firstName: "Trung",
593+
pageName: "LeDucTrung",
594594
position: "Technical Director",
595595
GitHubLink: "https://github.com/trungleduc",
596596
LinkedInLink: "https://www.linkedin.com/in/ductrung-le/",

‎src/components/about/index.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@ import FourValues from "./FourValues";
44
import SubTeam from "./SubTeam";
55
import LinkToContact from "../home/LinkToContact";
66

7-
export function getTeamByPersonName(name: string) {
7+
export function getTeamByPageName(name: string) {
8+
console.log('PageName:', name)
89
for (const [teamName, members] of Object.entries(teams)) {
9-
const person = members.find((person) => person.completeName.replace(/\s+/g, '').replace(/\s+/g, '').normalize("NFD").replace(/[\u0300-\u036f]/g, '') === name);
10+
const person = members.find((person) => person.pageName === name);
1011
if (person) {
1112
return members;
1213
}

0 commit comments

Comments
 (0)