-
Notifications
You must be signed in to change notification settings - Fork 8
Update to embedded-hal 1.0.0 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sorry alotta commits, i had to develop using CI because I don't have a linux box @RandomInsano This is ready to review |
All good, the noise doesn't bother me. From my quick scan of things it all looks good! I'd like to try and get this tested on my Pi... Do you want to do some conditional compilation for your platform and make sure you can run the examples you have hardware for? I don't mind reviewing a larger blob. Maybe a branch from this branch if you'd like to keep the history sane. If I can't get it tested by Monday I'll just merge it all in. |
Yeah that sounds good Since i'm targeting rp2350 I'm not sure I'll need any conditional compilation for my use case. I was thinking of adding more tests mainly through https://github.com/dbrgn/embedded-hal-mock but haven't used it before so I'll have to dig some more I'll do some personal tests based off this branch very soon and let you know how it goes |
I tested this PR with my board and everything seems to work fine |
Great! I'm convinced! Merging |
Had a very quick look at embedded-hal-mock and it's definitely the way to go. I don't think there's much value in mocking the different controller types but making sure everything on say the DualShock 2 works would be enough. The controllers themselves are never going to change, so we'd only want to test that we're using the HAL properly. |
A few misc changes:
The transfer method in embedded-hal 1.0.0 is called transfer_in_place
And some generic errors are now SPI::Error