🐛 Fix status process in tests (#361)

* Add build arg --dev to install dev dependencies

* Properly handle the exit code from tests

* Remove * at the end of COPY poetry.lock

* Simplify list of deps and add poetry.lock

* Remove unecessary echo

Author: hillairet

dev.sh

@@ -1,7 +1,7 @@
 # This is a dev file for testing the changes to this repo
 docker build . -t satel/python-base:latest
 cd tests/
-docker build . -t docker-python-base
+docker build . --build-arg DEVFLAG=--dev -t docker-python-base
 
 case $1 in
     run)

test_suite.sh

@@ -15,12 +15,12 @@ checkuser() {
 
 
 reportvalidation() {
-  if [ -z "$1" ]
+  if [ "$1" -eq 0 ]
   then
     echo "OK"
   else
     echo -e "\e[1m\e[91mFAILED\e[21m\e[39m"
-    echo "$1"
+    echo "$2"
   fi
 }
 
@@ -39,15 +39,18 @@ python -m pytest -vv --durations=3 --cov ./ --cov-report term-missing $PYTEST_RE
 
 echo -ne "$SECTION_PREFIX CHECK DOCKER USER IS PYTHON: "
 USEROUT=`checkuser`
-reportvalidation "$USEROUT"; STATUS2=$?
+STATUS2=$?
+reportvalidation "$STATUS2" "$USEROUT"
 
 echo -ne "$SECTION_PREFIX CHECK TYPING: "
 MYPYOUT=`mypy --cache-dir /home/python --no-error-summary . $MYPY_REPORTS`
-reportvalidation "$MYPYOUT"; STATUS3=$?
+STATUS3=$?
+reportvalidation "$STATUS3" "$MYPYOUT"
 
 echo -ne "$SECTION_PREFIX CHECK LINTING: "
 FLAKE8OUT=`flake8`
-reportvalidation "$FLAKE8OUT"; STATUS4=$?
+STATUS4=$?
+reportvalidation "$STATUS4" "$FLAKE8OUT"
 
 echo -ne "$SECTION_PREFIX CHECK FORMATTING: "
 BLACKOUT=`black --skip-string-normalization --line-length 99 ./ --check 2>&1`; STATUS5=$?
@@ -59,11 +62,10 @@ else
   echo "$BLACKOUT"
 fi
 
-echo
-
 echo -ne "$SECTION_PREFIX CHECK DOCSTRINGS: "
 INTERROGATEOUT=`interrogate`
-reportvalidation "$INTERROGATEOUT"; STATUS5=$?
+STATUS5=$?
+reportvalidation "$STATUS5" "$INTERROGATEOUT"
 
 if [[ $1 == "reports" ]]
 then
@@ -72,5 +74,5 @@ then
   echo
 fi
 
-TOTAL=$((STATUS1 + STATUS2 + STATUS3 + STATUS4 + STATUS5 + STATUS6))
+TOTAL=$((STATUS1 + STATUS2 + STATUS3 + STATUS4 + STATUS5))
 exit $TOTAL

tests/Dockerfile

@@ -4,7 +4,7 @@ ARG IMAGE_VERSION=satel/python-base:latest
 FROM python:3.10.5-slim AS requirements-stage
 
 RUN pip install poetry 
-COPY ./pyproject.toml ./poetry.lock* ./
+COPY ./pyproject.toml ./poetry.lock ./
 
 # Generate the requirement file 
 ARG DEVFLAG