Skip to content

[java] Add status endpoint #10832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2022
Merged

[java] Add status endpoint #10832

merged 2 commits into from
Jul 6, 2022

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Jun 30, 2022 •
edited
Loading

Related to #10725

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add /status endpoint as described in W3C spec

Motivation and Context

Add /status endpoint as described in W3C spec

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Merging #10832 (dd7ff50) into trunk (ed7d29e) will not change coverage.
The diff coverage is n/a.

❗ Current head dd7ff50 differs from pull request most recent head 23716a5. Consider uploading reports for the commit 23716a5 to get more accurate results

@@           Coverage Diff           @@
##            trunk   #10832   +/-   ##
=======================================
  Coverage   50.45%   50.45%           
=======================================
  Files          84       84           
  Lines        5480     5480           
  Branches      278      278           
=======================================
  Hits         2765     2765           
  Misses       2437     2437           
  Partials      278      278

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7d29e...23716a5. Read the comment docs.

diemol
diemol approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pujagani!

@pujagani pujagani merged commit 0a2a4a9 into SeleniumHQ:trunk Jul 6, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

diemol added a commit that referenced this pull request Aug 5, 2022
@diemol
[java] Revert - Add status endpoint
ad02160 
This reverts commit 0a2a4a9.

Feature did not reach a team consensus, hence reverting this
change #10832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pujagani @codecov-commenter @diemol