Skip to content

chore: fix CVEs #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

chore: fix CVEs #405

wants to merge 3 commits into from

Conversation

axi92
Copy link
Contributor

@axi92 axi92 commented Jul 18, 2025

Description

Fixes following vulnerabilities:

# npm audit report

@babel/helpers  <7.26.10
Severity: moderate
Babel has inefficient RegExp complexity in generated code with .replace when transpiling named capturing groups - https://github.com/advisories/GHSA-968p-4wvh-cqc8
fix available via `npm audit fix`
node_modules/@babel/helpers

brace-expansion  1.0.0 - 1.1.11 || 2.0.0 - 2.0.1
brace-expansion Regular Expression Denial of Service vulnerability - https://github.com/advisories/GHSA-v6h2-p8h4-qcjw
brace-expansion Regular Expression Denial of Service vulnerability - https://github.com/advisories/GHSA-v6h2-p8h4-qcjw
fix available via `npm audit fix`
node_modules/brace-expansion
node_modules/depcheck/node_modules/brace-expansion
node_modules/filelist/node_modules/brace-expansion
node_modules/glob/node_modules/brace-expansion

micromatch  <4.0.8
Severity: moderate
Regular Expression Denial of Service (ReDoS) in micromatch - https://github.com/advisories/GHSA-952p-6rrq-rcjv
fix available via `npm audit fix`
node_modules/micromatch

nanoid  <3.3.8
Severity: moderate
Predictable results in nanoid generation when given non-integer values - https://github.com/advisories/GHSA-mwcw-c2x4-8c55
fix available via `npm audit fix`
node_modules/nanoid

4 vulnerabilities (1 low, 3 moderate)

@soumyamahunt
Copy link
Contributor

Thanks for the PR @axi92, can you please run npm run all and commit the changes to dist/index.js. Just updating package dependencies in lock file won't fix the security issue as the dependencies are bundled in the dist/index.js file as well.

@axi92
Copy link
Contributor Author

axi92 commented Jul 22, 2025

Sure, I was just unsure if I have to commit that as well thats why I let it out =)

@axi92
Copy link
Contributor Author

axi92 commented Jul 22, 2025

I was not able to run the tests all green, are they supposed to work on ubuntu?

@soumyamahunt
Copy link
Contributor

I was not able to run the tests all green, are they supposed to work on ubuntu?

yes they are suppose to work on all supported platforms. In CI unit tests are working.

Can you add SETUPSWIFT_CUSTOM_TOOLCHAINS variable to your fork settings. The value should be:

{
    "ubuntu2204": "https://github.com/swiftwasm/swift/releases/download/swift-wasm-5.10-SNAPSHOT-2024-03-30-a/swift-wasm-5.10-SNAPSHOT-2024-03-30-a-ubuntu22.04_x86_64.tar.gz",
    "xcode": "https://github.com/swiftwasm/swift/releases/download/swift-wasm-5.10-SNAPSHOT-2024-03-30-a/swift-wasm-5.10-SNAPSHOT-2024-03-30-a-macos_x86_64.pkg",
    "windows10": ""
}

Currently integration tests are failing because this value is missing.

@axi92
Copy link
Contributor Author

axi92 commented Jul 22, 2025

I added it as a repo variable under action settings. That should make it available for the action.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.95%. Comparing base (cdf00ec) to head (2db7368).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          34       34           
  Lines        1175     1175           
  Branches      171      169    -2     
=======================================
  Hits         1104     1104           
- Misses         70       71    +1     
+ Partials        1        0    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@soumyamahunt
Copy link
Contributor

@axi92 it was still failing, I created a PR from your changes and have merged your changes with #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants